add tests on java 17 #177
Merged
add tests on java 17 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been out the loop for a little, is Spark on JDK 17 supported? |
lbergelson
force-pushed
the
lb_test_on_17
branch
from
ef769a1
to
806b949
Compare
|
@heuermh Spark 3.3.0 is supposed to support 17. |
|
@heuermh Would you have any objection to dropping support for java 8? |
Fine with me! |
heuermh
approved these changes
Jun 24, 2022
cmnbroad
reviewed
Feb 14, 2023
| --add-opens java.base/java.io=ALL-UNNAMED | ||
| --add-opens java.base/java.util=ALL-UNNAMED | ||
| --add-opens java.base/java.lang.invoke=ALL-UNNAMED | ||
| </argLine> |
There was a problem hiding this comment.
@lbergelson I know it seems sketchy, but I think this is just what you have to do. You should see the list for GATK....
We might want to extend this list to just automatically include all the ones used by spark (thats what I did for GATK).
lbergelson
force-pushed
the
lb_test_on_17
branch
from
6616e5c
to
317e083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing testing