Fix the default player size #58
Closed
+40
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktor-yunenko
force-pushed
the
1-fix-default-player-size
branch
4 times, most recently
from
be9d6d2 to
de147b8
Compare
viktor-yunenko
force-pushed
the
1-fix-default-player-size
branch
from
de147b8 to
445165e
Compare
FinalAngel
requested changes
Aug 18, 2020
| {% trans "Your browser doesn't support this video format." %} | ||
| </video> | ||
| {% endif %} | ||
| <link rel="stylesheet" type="text/css" href="{% static 'djangocms_video/video_player.css' %}"/> |
There was a problem hiding this comment.
can you use sekizai to load the css?
There was a problem hiding this comment.
please rather include it inline if we want to provide a "sample" css config
There was a problem hiding this comment.
I'm really reluctant doing this :D
|
@victor-yunenko I'm closing this for now. As mentioned, the following approach is acceptable: Adding an inline style for some initial styling when prototyping. Though we keep recommending adding your own style/framework to handle video display. The Addons default HTML/CSS should be bare-minimum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @FinalAngel, this is a css fix that I'm using for all my cms projects, would it be possible to merge it in?
Closes #57
It has been tested using youtube embed url and an uploaded mp4 file through Source plugin.