Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default the player has minimal size, eg 100x100 pixels, and editors don't know how to fix it #57

Closed
viktor-yunenko opened this issue Apr 4, 2020 · 1 comment · Fixed by #64

Comments

@viktor-yunenko
Copy link

For example:

Pasted_Image_20-Apr-04__21_02

It can be fixed by adding custom attributes width & height, but it isn't something an editor not familiar with HTML can do.

There's a css fix:

.djangocms-video-plugin {
    position: relative;
    padding-bottom: 56.25%;
    padding-top: 30px;
    height: 0;
    overflow: hidden;
    
    iframe, object, embed {
        position: absolute;
        top: 0;
        left: 0;
        width: 100%;
        height: 100%;
    }
}
@FinalAngel
Copy link
Member

For now rejected as per #57

macolo pushed a commit that referenced this issue Aug 14, 2021
resolves #57 and works around issues raised by @FinalAngel . The CSS can be added separately as per https://github.com/django-cms/djangocms-template frontend example however we don't want developers have to override this plugin's HTML template all the time.
macolo pushed a commit that referenced this issue Aug 14, 2021
resolves #57 and works around issues raised by @FinalAngel . The CSS can be added separately as per https://github.com/django-cms/djangocms-template frontend example however we don't want developers have to override this plugin's HTML template all the time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants