Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin code block must be identifiable by CSS #64

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Conversation

macolo
Copy link

@macolo macolo commented Aug 14, 2021

resolves #57 and works around issues raised by @FinalAngel . The CSS can be added separately as per https://github.com/django-cms/djangocms-template frontend example however we don't want developers have to override this plugin's HTML template all the time.

resolves #57 and works around issues raised by @FinalAngel . The CSS can be added separately as per https://github.com/django-cms/djangocms-template frontend example however we don't want developers have to override this plugin's HTML template all the time.
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2021

Codecov Report

Merging #64 (3af9807) into master (e5621b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          216       216           
  Branches         8         8           
=========================================
  Hits           216       216           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5621b7...3af9807. Read the comment docs.

@macolo macolo merged commit 9ff3469 into master Aug 14, 2021
@macolo macolo deleted the video-not-responsive branch August 14, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

By default the player has minimal size, eg 100x100 pixels, and editors don't know how to fix it
2 participants