Handle the HTTP request body as a spooled temp file. #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
force-pushed
the
http-body-handling-temporary-file
branch
from
06c191b to
f28377d
Compare
carltongibson
previously approved these changes
Sep 17, 2019
There was a problem hiding this comment.
Hey @hozblok. Thank you for this, and for your persistence. It looks great!
I've pushed a few edits in 06c191b
- Added a test for reading body after the stream, and removed the now redundant _read_started resets.
- Adjusted
read_body()slightly as theNonebranch isn't valid. c.f. https://code.djangoproject.com/ticket/30669
I'll look at this again in the light of day, and we'll get a release out.
Welcome aboard! Thanks again. 🏅
|
Hi @carltongibson , Your edits are appropriate! |
carltongibson
force-pushed
the
http-body-handling-temporary-file
branch
from
f28377d to
a28c889
Compare
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
carltongibson
force-pushed
the
http-body-handling-temporary-file
branch
from
a28c889 to
127303c
Compare
carltongibson
approved these changes
Sep 18, 2019
This was referenced Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1345 and #1251
Here is an excerpt from the changes: