-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#22667 replaced occurrences of master/slave terminology with leader/follower #2692
Conversation
#22667 replaced occurrences of master/slave terminology with leader/follower
Thanks for taking the time to do this! |
Are you serious ? NB: I don't say I'm against this change. Just that I don't see the point of changing two words with two others just because they have been used somewhere else. |
Is that a real life? |
As you can see from beec056 the terminology we have actually used is "primary/replica". So thank you for your interest, but there's nothing to see here and you can move along now. |
Before the flood of white male HN dwellers truly kicks off and obliterates all reasonable discussion, I'd like to thank the Django team for taking the time to do this. |
i'm just here for the laughs. is IT becoming too stupid? has science gone too far? |
Discussion on the ticket: https://code.djangoproject.com/ticket/22667 I cannot f_ing believe this PR made it through and was given actual man hours when there are massive outstanding PRs and patches on trac that need real attention. And don't be surprised that this does make it on HN and probably later on the usual slashdot/phoronix and what not. This is stupid *and_ controversial which is exactly what tech media loves. And to the HN/whatever crowd, don't post stupid memes here. This isn't the place. Help yourselves and revert this, guys. Django docs, or docs in general are not the place to make up new terms for stuff that already exists. PS: Quick heads up: This made it to 4chan and various other troll places. Do not be surprised if there's suddenly an influx of .. weird comments. |
This is silly. Sure, I understand that the use of words can hurt, but words themselves carry no meaning outside of it's use. Saying a car is yellow and calling a person yellow are two very different statements. We seem to have a new round of book burnings going on today... |
Guys, just ignore this. These are bots who do this automatically for projects, which have been circling around on Github lately. There are also ones about feminism etc. The Linux kernel also had a PR like this a few months ago with a massive amount of responses on it. Don't feed the trolls, and just continue to use |
Faith in humanity restored. Thank you guys. I just want to add, that this will also be bad for django itself, since almost every developer who is no aware of this will be confused, and trust me - he will be expecting that this is some bizarre django thing, not the well known pattern. Peace. |
Thanks so much Django for doing this thing! <3 |
Good move. Thank you. |
Excellent stuff. Thanks for doing that. |
I'm very glad for this change because as a PoC I felt very uncomfortable seeing and using this terminology in my code |
glad to see big projects taking this seriously |
Thanks Django for making this important change to be more welcoming and inclusive to more members of the tech community. <3 |
"they've always been called that" is a dumb reason to keep doing something, especially something that is hurtful or alienating. Kudos to Django for making this change! |
The use of the terms |
These terms have been in use forever, but that doesn't make them good. Fixing them has to start somewhere; good for Django for taking the lead. |
👍 |
Wow, this is awesome! Thanks! |
Thanks @fcurella! |
Thank you! :) |
Awesome change, thanks @fcurella! "Primary/replica" sounds much better. |
Excellent. |
Good. The old terminology should be made obsolete. |
@mannol1 >While the terms leader/followers are more politically correct |
Thank you to the Django developers -- leader/follower reads with much less baggage attached for me. |
I really don't care. Call it sun/earth, smurgasbordnic/flatuvalicxlkt, remove the feature, delete the documentation. I don't care, but please, just stop. All conceivable POVs have already been exposed ad nauseam. |
If only this sort of interest formed around more meaningful issues. Development should be free from political and social obligations and as such this is not much more than an end-user confusing step. On the other hand why not, if it pleases someone - it's just syntax. |
Should I make a PR for this, too? https://github.com/lukecarbis/django/compare/patch-1 |
Do you guys know why this silly commit got so many negative comments? I Because people tired of propaganda. Politicians tell us what we should and And it all turns into such a stupid thing as this commit. Do you know who are real slaves now? You. Those who say 'okaaay' when some Don't be sissy, fight for your freedom! 2014-05-30 7:48 GMT+07:00 Luke Carbis notifications@github.com:
|
I think we need to reform Python and its use of WHITEspace. This is all wrong. |
I think you should rename Django to something less offensive, because it can reffer to movie "Django Unchained" which contains slaves and violence! You should take example from http://www.vislab.uq.edu.au/nb/jokes/computers/pc_unix.html and take this seriously. |
I don't see how preferring the original terms is fallacious. In terms of documentation, it is genuinely confusing for documentation users to use terminology different from that which they're used to. One could argue that some people here have been using the appeal to novelty =p |
Don't you think this also reads a lil funny then: "Let's remove the terminology master and slave and merge our changes into django:M A S T E R" ;) Maybe you should change the branch name too (or is that ok because there are no slave branches ;-P ? ) |
Please. It is a valuable contribution.
|
@CaptainHayashi
Oh come on. How is that going to confuse anyone? People that dense won't make it through the tutorial anyway, let alone using multiple databases. If anything, the change makes the documentation more descriptive. And for "no one will be able to discover this", google "django master slave" and look at the first hit. Just the snippet provides you with enough information. Also this.
And that is what it describes, literally, in the context of this change (not accounting for lag/sync problems).
How original. But yes, you are correct, this was about the compound "master-slave" only. |
Oddly, the term is used in a lot of industries to describe a controller/dummy relationship. The railroad industry has used them for as long as they used multiple locomotives to move cargo. If we are going to be eliminating the term Master, what will replace the title of the college degree beyond Bachelor, but before Doctorate? How about the title of a higher ranked chess player or the head of a college? How about the phrase "he's a slave to his work" often meaning that he lets his work come before his personal life? What about remote control systems? Will we be renaming these communication links too? And lets not forget the religious implications. People that are devout are considered slaved to their master (God). Interesting responses on stackoverflow.com regarding this topic. One poster suggests using "pimp/ho". This entire topic is rubbish, and I find it offensive. |
👍 |
It is incredibly US-centric to assume that "master/slave" are "racially charged terms". There have been many societies where slaves and freemen were not separated along racial or ethnic lines, for example, the Roman Empire. Witness the cultural imperialism face of the PC movement at its finest! |
Fine, but this PR wasn't about any of that. It was very specifically about replacing "master/slave" with "primary/secondary" in the Django documentation on Multiple Databases, terms that are more descriptive and widely used. "Master" is still used in other contexts than database replication in the documentation. Nobody expressed a desire to change the term for higher ranked chess players.
Yes, very interesting. Thanks for sharing. Much constructive.
Now that is some kind of fresh madness. |
What's going on here? |
Ugh, this is bullshit. Why should anyone give a damn about the terminology? Keep your feels out of computing. |
Also, when did the social justice army invade GitHub? Nowhere is safe anymore. |
@Frogging101 Running around the Internet spouting incoherent subjective arguments to make oneself feel beneficial to the society is easier than writing good code. |
The true master here is a kind of linguistic puritanism to which, unfortunately, many are slavishly devoted. |
👍 |
Forget all the openly bigoted opinions ITT; this is a great PR! |
👍 |
"master/slave" is ungood crimethinkful oldspeak. plusgood rectify unword. |
Hi, i feel personally offended by racist name of this repo while it associates with tragic story of one american slave. I demand changing its name to "My Web Pony". |
The docs and some tests contain references to a master/slave db configuration.
While this terminology has been used for a long time, those terms may carry racially charged meanings to users.
This patch replaces all occurrences of master and slave with 'leader' and 'follower'