handle safe-string #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojb
reviewed
Jul 22, 2020
sha1_stubs.c
Outdated
| @@ -154,7 +154,7 @@ CAMLprim value stub_sha1_to_bin(value digest) | |||
| CAMLlocal1(result); | |||
|
|
|||
| result = caml_alloc_string(20); | |||
| sha1_to_bin((sha1_digest *) digest, String_val(result)); | |||
| sha1_to_bin((sha1_digest *) digest, &Byte(String_val(result), 0)); | |||
There was a problem hiding this comment.
Cleaner to use Bytes_val(result).
|
This macro is available since 4.06+, is such new dependency constraint intended?
A number of projects just add a compat define.
Not sure if snprintf can cope with unsigned char as input.
|
OK, then you can use |
String_val() will return 'const char *'. Signed-off-by: Olaf Hering <olaf@aepfle.de>
|
I have updated the change. |
|
Any idea if this MR is acceptable now? |
|
Changes look good, but it is up to the maintainer to merge it. cc @djs55 |
|
Thanks for the ping and the PR! Looks fine to me. |
djs55
added a commit
to djs55/opam-repository
that referenced
this pull request
Mar 15, 2021
CHANGES: - Handle `safe-string` by @olafhering, reviewed by @nojb (djs55/ocaml-sha#47) - Remove `--dev` option from `dune` invocation by @arthurteisseire (djs55/ocaml-sha#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String_val() will return 'const char *'.
Signed-off-by: Olaf Hering olaf@aepfle.de