Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to release v1.14 (a small update) #49

Merged
merged 5 commits into from
Mar 15, 2021
Merged

Prepare to release v1.14 (a small update) #49

merged 5 commits into from
Mar 15, 2021

Conversation

djs55
Copy link
Owner

@djs55 djs55 commented Mar 13, 2021

Signed-off-by: David Scott <dave@recoil.org>
This remains compatible with OCaml < 4.07 using the `stdlib-shims`
dependency.

Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
@olafhering
Copy link
Contributor

Shouldn't there be a (libraries stdlib-shims) added to the dune file in commit c5c309c?

The package was already a dependency in the dune-project file.

Signed-off-by: David Scott <dave@recoil.org>
@djs55
Copy link
Owner Author

djs55 commented Mar 14, 2021

@olafhering I think you're right. I hadn't spotted the difference between dune-project and dune. I've pushed a patch.

@olafhering
Copy link
Contributor

Thanks. Without this change it would not build with OCaml 4.06 and older, now it builds.

@djs55 djs55 merged commit c86a4c7 into master Mar 15, 2021
@djs55 djs55 deleted the release-v1.14 branch March 15, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants