Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad dub hash generation #528

Closed
0xEAB opened this issue Sep 3, 2018 · 1 comment
Closed

Bad dub hash generation #528

0xEAB opened this issue Sep 3, 2018 · 1 comment
Labels
Milestone

Comments

@0xEAB
Copy link

0xEAB commented Sep 3, 2018

My System: Linux 4.18 (x86-64), Ubuntu 18.04
Compiler: DMD v2.081.2, LDC v1.9.0 (DMD v2.079.1 and LLVM 6.0.0)

Problem

The dub hash generated by the pre-generate command is faulty.

bin/dubhash.txt:

v\00\00\000\00\00\00.\00\00\009\00\00\00.\00\00\001\00\00\001\00\00\00
\00\00\00

Pitfall

In a terminal one would usually not notice a difference, since it looks fine there:

$ dub --config=server -- --version
v0.9.11

$ cat bin/dubhash.txt 
v0.9.11

Results

Nevertheless, some other software won't implicitly get rid of the 0s. The following message is taken from code-d:

(target=0.9.8, installed=v���0���.���9���.���1���1��� ��� )
@ghost
Copy link

ghost commented Sep 4, 2018

Yeah it's a UTF-32 dstring.

@ghost ghost added the bug label Sep 4, 2018
@ghost ghost added this to the v0.9.13 milestone Sep 4, 2018
dlang-bot added a commit that referenced this issue Sep 4, 2018
fix #528 - Bad dub hash generation
merged-on-behalf-of: BBasile <BBasile@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant