Skip to content

Commit

Permalink
Remove export of unneeded dependencies in Dnn.React.Common bundle (#4467
Browse files Browse the repository at this point in the history
)

The common bundle goal was to put on the page stuff that most of our React modules use in order to reduce each of the bundles for individual modules at the cost of a larger common bundle. This is nice but several of the exported (Webpack Externals) packages are simply not used by any module or a single module.

This PR marks all of those derprecated for removal in v.10 except es6-primise which is a polyfill needed to support IE11 and it's used by some of the modules.
  • Loading branch information
valadas committed Feb 8, 2021
1 parent eca8bc2 commit 9730827
Showing 1 changed file with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,24 +1,34 @@
module.exports = {
"react": "window.dnn.nodeModules.React",
/** @deprecated for v.10 - will no longer be delivered. */
"react/lib/ReactMount": "window.dnn.nodeModules.ReactMount",
/** @deprecated for v.10 - will no longer be delivered. */
"react/lib/ReactComponentWithPureRenderMixin": "window.dnn.nodeModules.ReactComponentWithPureRenderMixin",
"redux": "window.dnn.nodeModules.Redux",
"react-redux": "window.dnn.nodeModules.ReactRedux",
"react-dom": "window.dnn.nodeModules.ReactDOM",
/** @deprecated for v.10 - will no longer be lelivered. */
"react-tabs": "window.dnn.nodeModules.ReactTabs",
/** @deprecated for v.10 - will no longer be lelivered. */
"redux-devtools": "window.dnn.nodeModules.ReduxDevTools",
/** @deprecated for v.10 - will no longer be lelivered. */
"redux-devtools-dock-monitor": "window.dnn.nodeModules.ReduxDevToolsDockMonitor",
/** @deprecated for v.10 - will no longer be lelivered. */
"redux-devtools-log-monitor": "window.dnn.nodeModules.ReduxDevToolsLogMonitor",
"redux-immutable-state-invariant": "window.dnn.nodeModules.ReduxImmutableStateInvariant",
"redux-thunk": "window.dnn.nodeModules.ReduxThunk",
"react-collapse": "window.dnn.nodeModules.ReactCollapse",
/** @deprecated for v.10 - will no longer be lelivered. */
"react-modal": "window.dnn.nodeModules.ReactModal",
"react-custom-scrollbars": "window.dnn.nodeModules.ReactCustomScrollBars",
/** @deprecated for v.10 - will no longer be lelivered. */
"react-tooltip": "window.dnn.nodeModules.ReactTooltip",
"react-widgets": "window.dnn.nodeModules.ReactWidgets",
/** @deprecated for v.10 - will no longer be lelivered. */
"throttle-debounce": "window.dnn.nodeModules.ThrottleDebounce",
/** @deprecated for v.10 - moment JS will no longer be delivered - recommended to manage own packages moving forward */
"moment": "window.dnn.nodeModules.Moment",
/** @deprecated for v.11 - will no longer be lelivered. */
"es6-promise": "window.dnn.nodeModules.Es6Promise",
"@dnnsoftware/dnn-react-common": "window.dnn.nodeModules.CommonComponents"
};

0 comments on commit 9730827

Please sign in to comment.