Deprecates dependencies in common bundle #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common bundle goal was to put on the page stuff that most of our React modules use in order to reduce each of the bundles for individual modules at the cost of a larger common bundle. This is nice but several of the exported (Webpack Externals) packages are simply not used by any module or a single module. This PR marks all of those derprecated for removal in v.10 except es6-primise which is a polyfill needed to support IE11 and it's used by some of the modules.
valadas
changed the title
mitchelsellers
approved these changes
Feb 8, 2021
donker
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common bundle goal was to put on the page stuff that most of our React modules use in order to reduce each of the bundles for individual modules at the cost of a larger common bundle. This is nice but several of the exported (Webpack Externals) packages are simply not used by any module or a single module.
This PR marks all of those deprecated for removal in v.10 except es6-promise which is a polyfill needed to support IE11 and it's used by some of the modules.
It also removes all development time only dependencies, which should not even be distributed. I was hoping for a big file reduction, but well, it will remove about 300Kb to the bundle when we do remove it, so it's better than nothing 🤷