-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiteSettings of type "RedirectAfter" are not saved correctly in a multi-lingual environment #4232
Comments
Looks like related to #4261 |
There where some localization issues resolved in the last few days, can you try if you can reproduce using this custom build to check if those fixes maybe resolved this: https://dev.azure.com/dotnet/DNN/_build/results?buildId=41521&view=artifacts&type=publishedArtifacts |
I took the following steps and ended up in a less than desired situation:
* I have a subscription in Plesk http://handsondnn.nl<http://handsondnn.nl/en-us/> (I do not own that domain but that is just a temp domain name)
* Add dnnacademy.tjeps.com as an alias in IIS
* Add dnnacademy.tjeps.com as site alias in DNN
* A record for dnnacademy.tjeps.com in DNS
I now have a working DNN on a live server
* Add language (Dutch)
* Enable language (at first this wasn't available but after 10 seconds the language was enabled automatically)
* Allow Content localization - Save
* Enable localized content
* Make all pages translatable
After this, the site goes to http://handsondnn.nl/en-us/ (which does not exist as I do not own that domain)
http://dnnacademy.tjeps.com/ redirects to that same url so that is not working either
http://dnnacademy.tjeps.com/nl-nl gives a 404 just like any page after that, so http://dnnacademy.tjeps.com/nl-nl/*
…________________________________
Van: Daniel Valadas <notifications@github.com>
Verzonden: dinsdag 10 november 2020 20:10
Aan: dnnsoftware/Dnn.Platform <Dnn.Platform@noreply.github.com>
CC: Tycho de Waard <info@tjeps.com>; Comment <comment@noreply.github.com>
Onderwerp: Re: [dnnsoftware/Dnn.Platform] SiteSettings of type "RedirectAfter" are not saved correctly in a multi-lingual environment (#4232)
There where some localization issues resolved in the last few days, can you try if you can reproduce using this custom build to check if those fixes maybe resolved this:
https://dev.azure.com/dotnet/DNN/_build/results?buildId=41521&view=artifacts&type=publishedArtifacts
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#4232 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACFLXHOHH7A2GTJ5G7J4ZELSPGFY5ANCNFSM4S2EBAMA>.
|
I am not sure what you mean, those aliases got added magically ? |
@valadas: by design, DNN does add aliases for currently used alias (or primary alias) for all active languages, when a second language is added. |
@sleupold I know, but what I don't understand is that in the setup @Tychodewaard mentions tjeps.com and then in the bug report it has handsondnn.nl the whole root domain is different. @Tychodewaard Can you rewrite the steps to reproduce more clearly. |
@valadas I recorded my scenario (3,5 minutes) on https://www.youtube.com/watch?v=M5IyS1HQP58 |
Ok, I see, well, from the looks of it, your primary domain does not resolve and that's the main issue here. |
Nope, I don't think that's it. |
@Tychodewaard no, this was not it, but there are definitely redirect issues. |
Idd @Timo-Breumelhof, imo none of the above is related to the issue I logged. Well, except for the fact that multi-lingual still does not seem to be a real priority. -- edited --
PortalSettings an Alias handling are closely related. That is why multi-lingual issues are often related to the PortalSettings rabbit hole. |
Well before digging too deep into this, is it not an expected behavior (by design) that it actually uses the primary alias ? |
AFAIK, design is to listen to the aliasses that are in the alias settings. I can not recall encountering this issue before. |
@valadas @Tychodewaard This issue is about Redirect_AfterLogin, not the portalalias... :-) |
We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. |
I have seen the same issue on dnn 9.8.0 |
@valadas This issue is easy to reproduce. You only need a multi-lingual site with two languages. |
We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. |
unstale
…________________________________
Van: stale[bot] ***@***.***>
Verzonden: woensdag 2 juni 2021 18:05
Aan: dnnsoftware/Dnn.Platform ***@***.***>
CC: Tycho de Waard ***@***.***>; Mention ***@***.***>
Onderwerp: Re: [dnnsoftware/Dnn.Platform] SiteSettings of type "RedirectAfter" are not saved correctly in a multi-lingual environment (#4232)
We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#4232 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACFLXHJFUK2CYVNREC74MK3TQZJDVANCNFSM4S2EBAMA>.
|
We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically. |
Cool, unstaled... |
…r localized sites. The settings for the current portal alias local where returned to the UI instead of the requested language picked in the Page Settings editor. This caused an issue where you would get let's say the english tabs for a french site settings if the last page you happend to visit was english instead of french. The user would then save any setting and all the RedirectAfters would save the wrong thing for that locale. Closes dnnsoftware#4232 Closes dnnsoftware#4260
…r localized sites. The settings for the current portal alias local where returned to the UI instead of the requested language picked in the Page Settings editor. This caused an issue where you would get let's say the english tabs for a french site settings if the last page you happend to visit was english instead of french. The user would then save any setting and all the RedirectAfters would save the wrong thing for that locale. Closes #4232 Closes #4260
Description of bug
Changing the Settings>Site Settings>RedirectAfterLogout in the default language works as expected. But fails in any other language of the portal.
Steps to reproduce
List the precise steps to reproduce the bug:
0. Make sure you have at least 2 languages active in your site, and you are in the default language part of the site
Current behavior
The TabId of the selected page is NOT saved correctly in table PortalSettings with SettingName='Redirect_AfterLogin'. CultureCode in not take into account.
The applies to all settings of this type:
RedirectAfterLoginTabId
RedirectAfterLoginTabName
RedirectAfterLogoutTabId
RedirectAfterLogoutTabName
RedirectAfterRegistrationTabId
RedirectAfterRegistrationTabName
Expected behavior
A new record should have been created in the PortalSettings, with the correct value and the correct Culture.
Additional context
Initial code analysis shows that to problem starts in GetDefaultPagesSettings() on lines 312/313
var portal = PortalController.Instance.GetPortal(pid, cultureCode);
var portalSettings = new PortalSettings(portal);
Here the PortalInfo variable 'portal' is correctly created (with the cultureInfo) and passed through to PortalSettings() constructor.
But clearly, down the line, the cultureInfo is not take into account when needed.
Affected version
The text was updated successfully, but these errors were encountered: