Resolved an issue where the wrong RedirectAfter tabs were showing for localized sites. #4851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r localized sites. The settings for the current portal alias local where returned to the UI instead of the requested language picked in the Page Settings editor. This caused an issue where you would get let's say the english tabs for a french site settings if the last page you happend to visit was english instead of french. The user would then save any setting and all the RedirectAfters would save the wrong thing for that locale. Closes dnnsoftware#4232 Closes dnnsoftware#4260
|
For reviewers, the first commit is the fix and the second commit cleans this file a bit to reduce about 200 warnings. |
david-poindexter
changed the title
mitchelsellers
approved these changes
Oct 3, 2021
|
Pulled this one locally seems to fix the issue on my site that was multi language. Do we think this fixes it for others too? |
This kinda fixes two things
So I do believe this should fix both problems. |
…is bug in the wrong place
david-poindexter
requested changes
Oct 4, 2021
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/SiteSettingsController.cs
Outdated
Show resolved
Hide resolved
david-poindexter
approved these changes
Oct 4, 2021
bdukes
approved these changes
Oct 4, 2021
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Oct 13, 2021
This is a follow up on dnnsoftware#4851 All my testing had been done on a localized site and after having those settings exist in the database. @david-poindexter just found out it was problematic on a clean install as those settings simply do not exists and the code failed getting those settings values from the dictionary of settings. This PR solves that.
bdukes
pushed a commit
that referenced
this pull request
Oct 13, 2021
This is a follow up on #4851 All my testing had been done on a localized site and after having those settings exist in the database. @david-poindexter just found out it was problematic on a clean install as those settings simply do not exists and the code failed getting those settings values from the dictionary of settings. This PR solves that.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings for the current portal alias local were returned to the UI instead of the requested language picked in the Page Settings editor. This caused an issue where you would get let's say the English tabs for a french site setting if the last page you happened to visit was English instead of french. The user would then save any setting and all the RedirectAfters would save the wrong thing for that locale.
Closes #4232
Closes #4260