Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling missing for personabar in IE11 #4787

Closed
1 task
schotman opened this issue Aug 19, 2021 · 9 comments · Fixed by #4790
Closed
1 task

Styling missing for personabar in IE11 #4787

schotman opened this issue Aug 19, 2021 · 9 comments · Fixed by #4790

Comments

@schotman
Copy link
Contributor

schotman commented Aug 19, 2021

Description of bug

Because of the use of CSS variables the personabar looks pretty bad. I do encourage the use of modern tech, this issue could be easily have been prevented.

Steps to reproduce

open de site as an admin, you'll see

Current behavior

styling issues, most obvious, missing backgrounds

Expected behavior

What we had...

Affected version

version 09.10.00

Affected browser

  • Internet Explorer 11
    ie11-issue-personabar
@mitchelsellers
Copy link
Contributor

Support for IE 11 is ending, Can you provide examples of what your are seeing

@bdukes
Copy link
Contributor

bdukes commented Aug 19, 2021

That said, I don't think we've officially declared that the DNN Platform doesn't support IE 11. And we're certainly not opposed to PRs that add a better experience for IE 11 (so long as they don't significantly detract from the experience on newer browsers, e.g. due to performance issues)

@schotman
Copy link
Contributor Author

I will add a pull request with some non-interfering styles

@WillStrohl
Copy link
Contributor

Ah... Mitch and Brian beat me to it. 😃

@Timo-Breumelhof
Copy link
Contributor

That said, I don't think we've officially declared that the DNN Platform doesn't support IE 11. And we're certainly not opposed to PRs that add a better experience for IE 11 (so long as they don't significantly detract from the experience on newer browsers, e.g. due to performance issues)

I hate IE just a much as most of you, but using HTML/CSS not supported by IE would probably be better for a major version. :-)
I have logged issues before where a minor change of (incorrect) HTML was seen as a breaking change.

@schotman
Copy link
Contributor Author

just added an image to the issue of what you get when using IE11 (a not uncommon scenario when updating a site on a webserver)

@schotman
Copy link
Contributor Author

Ah... Mitch and Brian beat me to it. 😃

I was kind of reluctant to post this issue because it is obvious that IE11 is old crap, but on a server it is often the only browser, and when you update there e.g. from 9.9 to 9.10 you get a nasty surprise, and you might even think the update went wrong.
We should not want the average IT Joe to think that...

@WillStrohl
Copy link
Contributor

I was kind of reluctant to post this issue because it is obvious that IE11 is old crap, but on a server it is often the only browser

Yes. That's the app you use to download an actual web browser. 😉😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants