Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected some styling issues with IE11 #4790

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Corrected some styling issues with IE11 #4790

merged 1 commit into from
Sep 10, 2021

Conversation

schotman
Copy link
Contributor

@schotman schotman commented Aug 20, 2021 •
edited by valadas
Loading

Closes #4787

Summary

added IE specific styling by means of a media query

@Timo-Breumelhof
Copy link
Contributor

#4787

@schotman schotman changed the title IE11 corrections IE11 corrections fixes #4787 Aug 27, 2021
@bdukes bdukes added this to the 9.10.2 milestone Sep 3, 2021
valadas
valadas approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this in a 9.x.x release, not sure yet what our stance will be in the future for IE11 support vs going lean. But here it does not impact other browsers and the added lines are very minimal, so I am ok with this.

mitchelsellers
mitchelsellers approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @valadas on this item, thanks for the contributions!

@mitchelsellers mitchelsellers merged commit 1d6d67a into dnnsoftware:develop Sep 10, 2021
@schotman schotman deleted the issue_4787 branch September 13, 2021 12:34
@valadas valadas changed the title IE11 corrections fixes #4787 Corrected some styling issues with IE11 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
9.10.2
Development

Successfully merging this pull request may close these issues.

Styling missing for personabar in IE11
5 participants
@schotman @Timo-Breumelhof @mitchelsellers @valadas @bdukes