Support C# Async Constructs During Page Rendering #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation to move the Localization.SetThreadCultures call to an HttpModule.
This is in support of turning on Async for Default.aspx. Per a discussion with the ASP.NET team, setting the thread culture in OnInit for a page does not persist in the context for the page (once Async is turned on an there are multiple contexts to consider). Setting it from an IHttpModule implementation, however, will persist throughout that request. This fixes the bug that plagued dnnsoftware#2089, where, as an example, URLs would be generated for the incorrect language once Async was on.
This is a second try for 0cf1b13 dnnsoftware#2089. This will allow for async calls from WebForms controls (preferably via calling RegisterAsyncTask, see https://docs.microsoft.com/en-us/aspnet/web-forms/overview/performance-and-caching/using-asynchronous-methods-in-aspnet-45#registerasynctask-notes)
|
This is fantastic! |
|
This is awesome. I’ll review over the weekend |
|
Whohoo |
mitchelsellers
approved these changes
Aug 18, 2020
david-poindexter
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thanks @mitchelsellers for tracking down the answer to our
asyncissues.This turns on
AsyncforDefault.aspx.Previously, when we attempted this in #2089, we ran into an issue with the culture not being preserved throughout the entire page lifecycle. So, for example, the page may have been loaded in a non-English context, but the URLs were generated for en-US anyway.
The solution is to set the thread culture via an
IHttpModuleimplementation, rather than via the page'sOnInitmethod. This allows the culture to persist throughout the page request.