Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support C# Async Constructs During Page Rendering #3984

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Support C# Async Constructs During Page Rendering #3984

merged 3 commits into from
Oct 6, 2020

Commits on Aug 14, 2020

  1. Use IPortalSettings in Localization APIs 

    This is in preparation to move the Localization.SetThreadCultures call
to an HttpModule.
    @bdukes
    bdukes committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    5e3bf19 View commit details
    Browse the repository at this point in the history

  2. Move Localization.SetThreadCultures to HttpModule 

    This is in support of turning on Async for Default.aspx. Per a
discussion with the ASP.NET team, setting the thread culture in OnInit
for a page does not persist in the context for the page (once Async is
turned on an there are multiple contexts to consider). Setting it from
an IHttpModule implementation, however, will persist throughout that
request.

This fixes the bug that plagued dnnsoftware#2089, where, as an example, URLs would
be generated for the incorrect language once Async was on.
    @bdukes
    bdukes committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    e5364f1 View commit details
    Browse the repository at this point in the history

  3. Add Async support to Default.aspx 

    This is a second try for 0cf1b13 dnnsoftware#2089.
This will allow for async calls from WebForms controls (preferably via
calling RegisterAsyncTask, see https://docs.microsoft.com/en-us/aspnet/web-forms/overview/performance-and-caching/using-asynchronous-methods-in-aspnet-45#registerasynctask-notes)
    @bdukes
    bdukes committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    b418431 View commit details
    Browse the repository at this point in the history