Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide new members that differ only by case #4139

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Hide new members that differ only by case #4139

merged 1 commit into from
Sep 28, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Sep 28, 2020

Addresses CA1708

Identifiers for namespaces, types, members, and parameters cannot
differ only by case because languages that target the common language
runtime are not required to be case-sensitive. For example, Visual
Basic is a widely used case-insensitive language.

Fixes #4138

@bdukes bdukes added this to the 9.7.3 milestone Sep 28, 2020
mitchelsellers
mitchelsellers approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

valadas
valadas approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, love it.

@valadas
Copy link
Contributor

valadas commented Sep 28, 2020

Build failed though...

@valadas
Copy link
Contributor

valadas commented Sep 28, 2020

Those are the errors:

(CoreCompile target) -> 
         Entities\Portals\PortalAliasInfo.cs(51,37): error CS0106: The modifier 'public' is not valid for this item [D:\a\1\s\DNN Platform\Library\DotNetNuke.Library.csproj]
         Entities\Portals\PortalAliasInfo.cs(61,37): error CS0106: The modifier 'public' is not valid for this item [D:\a\1\s\DNN Platform\Library\DotNetNuke.Library.csproj]

valadas
valadas requested changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing...

@bdukes
Copy link
Contributor Author

bdukes commented Sep 28, 2020

Yup, sorry about that. I've pushed a new commit with a more complete fix.

@valadas
Copy link
Contributor

valadas commented Sep 28, 2020

Hmm, nice sorcery there :) Where is ThisAsInterface defined though ?

@bdukes
Copy link
Contributor Author

bdukes commented Sep 28, 2020

Line 107

Dnn.Platform/DNN Platform/Library/Entities/Portals/PortalAliasInfo.cs

Line 107 in 6e720cb

private IPortalAliasInfo ThisAsInterface => this;

@bdukes
Copy link
Contributor Author

bdukes commented Sep 28, 2020

Hmmm, build is still broken. I wonder why it told me it was successful on my local…

@valadas
Copy link
Contributor

valadas commented Sep 28, 2020

Line 107

Dnn.Platform/DNN Platform/Library/Entities/Portals/PortalAliasInfo.cs

Line 107 in 6e720cb

private IPortalAliasInfo ThisAsInterface => this;

Oh, sound good, my eyes where not seeing that :)

@bdukes
Hide new members that differ only by case
ca12042 
Addresses CA1708
>Identifiers for namespaces, types, members, and parameters cannot
>differ only by case because languages that target the common language
>runtime are not required to be case-sensitive. For example, Visual
>Basic is a widely used case-insensitive language.

Fixes dnnsoftware#4138
@bdukes
Copy link
Contributor Author

bdukes commented Sep 28, 2020

Alright, build's green now 🟢

@bdukes bdukes requested a review from valadas September 28, 2020 15:43
valadas
valadas approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks all good now

@valadas valadas merged commit 5928a07 into dnnsoftware:develop Sep 28, 2020
@david-poindexter
Copy link
Contributor

Great work on this @bdukes - I'm sure @Timo-Breumelhof and all the other VB extension devs out there will really appreciate the quick resolve to this one!

@bdukes bdukes deleted the bug/portal-alias-api branch October 1, 2020 13:25
@valadas valadas modified the milestones: 9.7.3, 9.8.0 Oct 7, 2020
@bdukes bdukes mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.

Renaming PortalSettings.PortalAlias.HTTPAlias to HttpAlias crashes VB extensions
4 participants
@bdukes @valadas @david-poindexter @mitchelsellers