Remove member with case-sensitive naming conflict #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PortalInfo.PortalId was introduced in DNN 9.7.2, but should have been made private (i.e. should have been an explicit interface implementation), in order to avoid breaking case insensitive languages (e.g. VB.NET)
mitchelsellers
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PortalInfo.PortalIdwas introduced in DNN 9.7.2, but should have been made private (i.e. should have been an explicit interface implementation), in order to avoid breaking case insensitive languages (e.g. VB.NET)I'm not sure this is the right solution, since it will be breaking to anyone using the new member for the last three releases (whereas with #4139 we resolved an issue introduced in 9.7.2 in 9.7.3).