Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-4386 - Cannot Create Pages of Type "File" #4387

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

berkarslan-xo
Copy link
Contributor

Fixes #4386

Summary

Validation code was not getting passed to PageFile.jsx which is fixed now. The code gets sent to the file upload control along the chain.

Demo: https://drive.google.com/file/d/1rcSV2QK1p9Yp54Zde-Cbcim44j6wPbQ5/view

@berkarslan-xo
Copy link
Contributor Author

Hi community, happy new year!

Can someone take a look at this PR to review it, please?

CC @bdukes @mitchelsellers

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me

@bdukes bdukes added this to the 9.9.0 milestone Jan 6, 2021
@bdukes bdukes merged commit 4689315 into dnnsoftware:develop Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Create Pages of Type "File"
3 participants