Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Compress Images GitHub Actions workflow #4478

Merged

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Feb 10, 2021

The Compress Images workflow isn't catching most of the images being
committed. This is, in part, because it doesn't run with permissions to
edit PRs on forks. This updates the configuration to open a new PR when
a commit is merged, if there are images that can be compressed. It also
adds a scheduled run, in case something gets missed.

Based on https://github.com/calibreapp/image-actions#combined-workflow

The Compress Images workflow isn't catching most of the images being
committed. This is, in part, because it doesn't run with permissions to
edit PRs on forks.  This updates the configuration to open a new PR when
a commit is merged, if there are images that can be compressed. It also
adds a scheduled run, in case something gets missed.
Based on https://github.com/calibreapp/image-actions#combined-workflow
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@valadas valadas added this to the 9.9.1 milestone Feb 10, 2021
@donker donker merged commit ec762ba into dnnsoftware:develop Mar 2, 2021
@bdukes bdukes deleted the update-cailbre-image-actions-workflow branch March 5, 2021 19:57
@bdukes bdukes mentioned this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants