Optimize images #4480
Merged
Optimize images #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I doubt, compressing editor icons and smileys will have a big size benefit - will this really improve performance? |
mitchelsellers
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
This looks good. @sleupold the reduction here is > 50% on average per file, considering multiple images are loaded there is a good gain. Additionally, as part of our continuous improvement efforts we should be optimizing everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have new images in DNN 9.9.0 that didn't get optimized (see #4478 for a related fix to the workflow). This PR is just a rebase of the automatic commit from the release branch with those optimizations.