Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-collapse from 4.0.3 to 5.1.0 #4808

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2021

Bumps react-collapse from 4.0.3 to 5.1.0.

Release notes

Sourced from react-collapse's releases.

v5.1.0

Added:

  • #281 Allow React 17 as peer dependency by @​davidspiess
  • #262 Accessibility enhancements (added area-hidden to Collapse container depending on isOpened) by @​kylemh

Fixes:

  • #285 Remove hasNestedCollapse from example as it not necessary
  • #284 Update all dependencies

v5.0.1

FIX

  • #257 Avoid using Object.assign so IE11 works again

v5.0.0

Another full rewrite comparing to v4. For most cases upgrade should cause much troubles (except you need to add CSS transition to your collapse element)

Please see https://github.com/nkbt/react-collapse#migrating-from-v4-to-v5 for full migration guide

Updates from 5.0.0-alpha.3 (see #251 and #252)

  • renamed onRestCheckInterval -> checkTimeout prop
  • fix initialStyle.height prop type
  • added ForceInitialAnimation example
  • updated Readme with all the v5 changes and Migration Guide

v5.0.0-alpha.3

Fixes

#249 - Fixed UnmountClosed to work with latest React

Chores

#248 - Updated all dependencies and build

v5.0.0-alpha.2

#229

  • completely rewrote collapse again 🤦‍♂️ no more iframe and onresize listeners
  • now we get height: auto; and overflow: initial when component is fully opened and not resizing anymore (resting)
  • due to getSnapshotBeforeUpdate usage, React peer bumped to ^16.3.0
  • added onRest and onWork callbacks
  • re-implemented UnmountCollapsed component

v5.0.0-alpha.0

#222 Complete Rewrite

Lots of breaking changes, will try to get API as close to the 4.x as possible over time and add Migration docs.

Commits
  • a6ee480 5.1.0
  • c812ba6 Merge pull request #285 from nkbt/deprecated-hasNestedCollapse
  • e8790b5 Remove hasNestedCollapse from example as it not necessary
  • 444f6b9 Merge pull request #284 from nkbt/update
  • 03db880 Adjust eslint config harder
  • 844c33d Add deps audit and update CI Node version
  • 5ffbd4f Fix Accessible example to avoid React warnings
  • 1817cf2 Update configs for upgraded libs
  • abf3128 upgrade deps
  • f62d23e .packages
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added javascript Pull requests that update Javascript code Type: Maintenance labels Sep 1, 2021
@bdukes bdukes added this to the 9.10.2 milestone Sep 3, 2021
@bdukes bdukes force-pushed the dependabot/npm_and_yarn/react-collapse-5.1.0 branch from 4590569 to b63b6f3 Compare September 3, 2021 16:01
@valadas
Copy link
Contributor

valadas commented Sep 6, 2021

This needs some good UI testing

@valadas valadas modified the milestones: 9.10.2, 9.10.3 Oct 5, 2021
@mitchelsellers
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 14, 2021

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Bumps [react-collapse](https://github.com/nkbt/react-collapse) from 4.0.3
to 5.1.0.
- [Release notes](https://github.com/nkbt/react-collapse/releases)
- [Commits](nkbt/react-collapse@v4.0.3...v5.1.0)

---
updated-dependencies:
- dependency-name: react-collapse
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@bdukes bdukes force-pushed the dependabot/npm_and_yarn/react-collapse-5.1.0 branch from b63b6f3 to f8a31e0 Compare November 15, 2021 14:28
@bdukes
Copy link
Contributor

bdukes commented Nov 15, 2021

@mitchelsellers this has been rebased

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 1, 2021

A newer version of react-collapse exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@valadas
Copy link
Contributor

valadas commented Mar 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stale
Copy link

stale bot commented Jul 10, 2022

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

@stale stale bot added the stale label Jul 10, 2022
@bdukes bdukes merged commit 6f34381 into develop Jul 19, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/react-collapse-5.1.0 branch July 19, 2022 19:29
@bdukes bdukes mentioned this pull request Jul 29, 2022
@valadas valadas modified the milestones: 9.10.3, 9.11.0 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code stale Type: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants