React-collapse fixes #5213
Merged
React-collapse fixes #5213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unused fixedHeight prop from Dropdown
bdukes
added
javascript
valadas
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves issues introduced by #4808, where the react-collapse library switched to CSS-based animations.
It also removed support for pass-through props, so any usage of
styleorclassNamehad to be adjusted.The
fixedHeightprop is now "implicitly supported", so each of those props needed to be converted to CSS that targeted the child of the collapse element.The
keepCollapsedContentis now the default behavior. There's a separate component which unmounts the content when collapsed. I have not made use of that separate component, but didn't see any issues from places where previously the content had been unmounted by default.