-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top level pages #5118
Top level pages #5118
Conversation
Use home page permissions as default when creating a top level page Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/PagesControllerImpl.cs Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj
Undid some changes no longer needed Added SQL for PortalPermission Table and related SPs Platform/Website/Providers/DataProviders/SqlDataProvider/09.11.00.SqlDataProvider Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/PagesControllerImpl.cs Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Added PortalPermission Controller class Added PortalPermission Info class Added PortalPermission Collection class Expanded PortalPermission Table Added vw_PortalPermission View Added SPs for PortalPermission Added data providers for PortalPermission Added PortalPermission to PortalInfo Added Helper functions for PortalPermission Added caching for PortalPermission Fixed spelling errors Platform/Website/Providers/DataProviders/SqlDataProvider/09.11.00.SqlDataProvider Platform/Website/Providers/DataProviders/SqlDataProvider/UnInstall.SqlDataProvider
I strictly disagree to creating an new table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this solution, there shouldn't be created yet another table for specific page permissions. please use existing table TabPermissions according to the discussion of this feature.
@sleupold these permissions don't pertain to a specific tab, they pertain to all of the tabs in a portal, so we can't use the |
Added PortalPermission checks to PermissionProvider Changed Permission Codes Use Home page permissions as default when adding top level pages New tabs created in GetTabById now set PortalId to current portal Platform/Website/Providers/DataProviders/SqlDataProvider/09.11.00.SqlDataProvider Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/PagesControllerImpl.cs Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/Security/SecurityService.cs Dnn.AdminExperience/Dnn.PersonaBar.Extensions/MenuControllers/PagesMenuController.cs
This PR is ready for review. It adds the concept of It also adjusts the default permissions when adding a top-level page to be a copy of the home page (in an attempt to avoid scenarios where users are creating pages that they cannot access). This PR does not include frontend changes to manage these new permissions. At the present time they are managed only through the database. Let us know if the existence of a management UI is a blocker. /cc @DanielBolef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great enhancement IMHO
…l-pages" This reverts commit 7a34b6f, reversing changes made to 327b1f5. Platform/Website/Providers/DataProviders/SqlDataProvider/09.11.00.SqlDataProvider Platform/Website/Providers/DataProviders/SqlDataProvider/UnInstall.SqlDataProvider Dnn.AdminExperience/ClientSide/Pages.Web/src/services/securityService.js Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/PagesControllerImpl.cs Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/Security/SecurityService.cs Dnn.AdminExperience/Dnn.PersonaBar.Extensions/MenuControllers/PagesMenuController.cs Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Revert "Merge pull request #5118 from DanielBolef/top-level-pages"
We just have one problem here, this was slated for 9.11.0 but got merged into develop. |
Oh, sorry I missed that... |
Fixes #5103
This PR grants add page permissions for top level pages to users that have add page permissions for the home page. Also adjusts default permissions of new top level pages to match those of the home page so that users are less likely to create pages they cannot edit.