Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Top level pages" on release/9.11.0 #5209

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jul 28, 2022

Replays #5118 on release/9.11.0 (it was originally incorrectly merged into develop).

Use home page permissions as default when creating a top level page
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Pages/PagesControllerImpl.cs
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj
Undid some changes no longer needed
Added SQL for PortalPermission Table and related SPs
Added PortalPermission Controller class
Added PortalPermission Info class
Added PortalPermission Collection class
Expanded PortalPermission Table
Added vw_PortalPermission View
Added SPs for PortalPermission
Added data providers for PortalPermission
Added PortalPermission to PortalInfo
Added Helper functions for PortalPermission
Added caching for PortalPermission
Fixed spelling errors
Added PortalPermission checks to PermissionProvider
Changed Permission Codes
Use Home page permissions as default when adding top level pages
New tabs created in GetTabById now set PortalId to current portal
@bdukes bdukes added this to the 9.11.0 milestone Jul 28, 2022
@bdukes bdukes requested a review from valadas July 28, 2022 13:15
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donker donker merged commit 42f1820 into dnnsoftware:release/9.11.0 Jul 29, 2022
@bdukes bdukes deleted the top-level-pages branch August 2, 2022 16:18
@bdukes bdukes mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants