Remove dependency on SharpZipLib #5127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdukes
approved these changes
Jun 7, 2022
|
It's difficult for no reason to track changes when functions are completely removed and then added back in later with an additional obsolete tag. The solution that @bdukes started was much cleaner for the removal of SharpZipLib. |
mitchelsellers
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
This looks good, and I did test this was working, however, @valadas I believe you had some feedback on this PR? Can you confirm that you are also ok with this? If so, please merge
|
Nah, I am good with it, my concern was with build packaging, but that part is not distributed, so good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2735