-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade SharpZipLib from 0.86.0 to 1.3.3 #5185
Upgrade SharpZipLib from 0.86.0 to 1.3.3 #5185
Conversation
Rather than referencing SharpZipLib from Dnn.PersonaBar.Extensions, this uses named arguments to help the compiler find the correct overload (since the deprecated overload's first parameter is in PascalCase and the new overload's first parameter is in camelCase). Also some style clean-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
Is this removal of SharpLib announced in advance? We now have 3rd party modules break because SharpLib is no longer there. |
@schotman this PR was not intended to remove SharpZipLib from the installation, that was an oversight. Thanks for testing! I'll be submitting a PR to add the SharpZipLib library to the installation |
Thanks, Question: do we want to remove SharpLibZip in a future upgrade? if so we need to inform 3rd party module devs |
Yes, the APIs that depend on SharpZipLib have been marked as deprecated and will be removed in v11.0.0. Our current intention is that we would remove SharpZipLib at that time. Any 3rd party module could then start including SharpZipLib if they require it, or migrate to |
Summary
This PR upgrades SharpZipLib to the latest version.
Potential breaking changes include:
ICSharpCode.SharpZipLib.Checksums
namespace has been renamedICSharpCode.SharpZipLib.Checksum
.