Upgrade SharpZipLib from 0.86.0 to 1.3.3 #5185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than referencing SharpZipLib from Dnn.PersonaBar.Extensions, this uses named arguments to help the compiler find the correct overload (since the deprecated overload's first parameter is in PascalCase and the new overload's first parameter is in camelCase). Also some style clean-up
This was referenced Jul 5, 2022
Closed
Closed
|
Is this removal of SharpLib announced in advance? We now have 3rd party modules break because SharpLib is no longer there. |
|
@schotman this PR was not intended to remove SharpZipLib from the installation, that was an oversight. Thanks for testing! I'll be submitting a PR to add the SharpZipLib library to the installation |
|
Thanks, Question: do we want to remove SharpLibZip in a future upgrade? if so we need to inform 3rd party module devs |
|
Yes, the APIs that depend on SharpZipLib have been marked as deprecated and will be removed in v11.0.0. Our current intention is that we would remove SharpZipLib at that time. Any 3rd party module could then start including SharpZipLib if they require it, or migrate to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades SharpZipLib to the latest version.
Potential breaking changes include:
ICSharpCode.SharpZipLib.Checksumsnamespace has been renamedICSharpCode.SharpZipLib.Checksum.