Feature/5101 ck editor resize images on upload #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have seen the failed test fail for no reason so re-firing the build to see... |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
seems to have worked now |
valadas
approved these changes
May 30, 2022
bdukes
approved these changes
May 31, 2022
Comment on lines
2510
to
2512
| var fileStream = FileManager.Instance.GetFileContent(uploadedFile); | ||
| var uplImage = Image.FromStream(fileStream); | ||
| fileStream.Close(); |
There was a problem hiding this comment.
These need to be disposed, right?
Suggested change
| var fileStream = FileManager.Instance.GetFileContent(uploadedFile); | |
| var uplImage = Image.FromStream(fileStream); | |
| fileStream.Close(); | |
| using (var fileStream = FileManager.Instance.GetFileContent(uploadedFile)) | |
| using (var uplImage = Image.FromStream(fileStream)) | |
| { |
| using (Image newImage = uplImage.GetThumbnailImage(newWidth, newHeight, null, IntPtr.Zero)) | ||
| { | ||
| var imageFormat = uplImage.RawFormat; | ||
| uplImage.Dispose(); |
There was a problem hiding this comment.
Switching to using from Dipose()
Suggested change
| uplImage.Dispose(); |
DNN Platform/Providers/HtmlEditorProviders/DNNConnect.CKE/Browser/Browser.aspx.cs
Show resolved
Hide resolved
|
@bdukes thanks for your comments, Do I need to commit your changes? Or did you already do the changes? (I'm a bit scared to mess it up again :-) ) |
|
I have not applied the changes, you can go ahead and do that. Thanks! |
Did that just now, tnx |
|
Awesome, thanks @skamphuis |
This was referenced Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a redo of #5123 because of merge/rebase issues. As @valadas advised, I cherry picked the relevant commits, and gave it a quick test based on a fresh 9.11.0 install.
Closes #5101
This PR is built on PR #5122 which was submitted for #5100, but is not necessarily related.
Summary
This PR adds settings for:
And will resize any uploaded image to fit within these dimension on upload.
Since pictures are becoming larger and larger, it can be important on many portals, to have this automatic resize option, to allow users uncapable of resizing images themselves, to upload reasonably sized images.
