Fixed a bug that prevented selecting folders for Browser Root and Default Upload folders in HtmlEditor #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…p-address-with-proxy Feature/eventlog ip address with proxy
Migrate moment to dayjs for Dnn.PersonaBar.UI
* HTML tags are added to array * Reverting back <> replace breaks other features Co-authored-by: armaganpekatik <armagan.pekatik@trilogy.com>
donker
approved these changes
May 12, 2022
|
Note: the changes in #5123 include the changes in this PR. |
|
@skamphuis can we get a comparison between this one #5122 and #5123, as it does not appear that this one has everything from the other, but it does have some. Ideally, I'd like to see if we can get to a single PR for these changes |
valadas
changed the title
|
@mitchelsellers I can create a single pr for them if that's easier. I based the second feature branch on the first, so I'm pretty sure the last one contains all change. But let me just create a single pr for both changes and go from there. I will do so in the morning. |
|
Oh, I just merged this one and will help on the other if a rebase is needed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5100
Summary
This PR adds settings for
These settings are used when the user opens the browser for images, or uploads an image.
Often, it is desirable that images are kept separated from documents, and with these settings, it is no longer up to the content editor to remember to select the correct folder.