-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a bug that prevented selecting folders for Browser Root and Default Upload folders in HtmlEditor #5122
Fixed a bug that prevented selecting folders for Browser Root and Default Upload folders in HtmlEditor #5122
Conversation
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…p-address-with-proxy Feature/eventlog ip address with proxy
Migrate moment to dayjs for Dnn.PersonaBar.UI
* HTML tags are added to array * Reverting back <> replace breaks other features Co-authored-by: armaganpekatik <armagan.pekatik@trilogy.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Nice feature.
Note: the changes in #5123 include the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
@skamphuis can we get a comparison between this one #5122 and #5123, as it does not appear that this one has everything from the other, but it does have some. Ideally, I'd like to see if we can get to a single PR for these changes |
@mitchelsellers I can create a single pr for them if that's easier. I based the second feature branch on the first, so I'm pretty sure the last one contains all change. But let me just create a single pr for both changes and go from there. I will do so in the morning. |
Oh, I just merged this one and will help on the other if a rebase is needed... |
Closes #5100
Summary
This PR adds settings for
These settings are used when the user opens the browser for images, or uploads an image.
Often, it is desirable that images are kept separated from documents, and with these settings, it is no longer up to the content editor to remember to select the correct folder.