Added support for HtmlAttributesAsString in html module views #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for HtmlAttributesAsString in html module views.
…l-attributes-as-string
valadas
added a commit
to valadas/DNNDocs
that referenced
this pull request
Aug 31, 2022
This assumes that dnnsoftware/Dnn.Platform#5242 gets merged first...
david-poindexter
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
This looks great to me. I really appreciate the more understandable logic here too. That was some confusing logic before. Thank you @valadas 🎉 🌮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for HtmlAttributesAsString in html module views.
Also makes the resource manager use this so it works with sub-portals, etc.