Improve HTML attribute support in client resource manager #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invert if statements where it simplifies logic Use null propagation Consolidate XML comments Fix typos Make static fields readonly
valadas
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
This is awesome, even cleaner.
I used empty dictionaries so it does not get confused and hit the wrong overload (multiple strings passing nulls), never thought about using the parameter name to resolve that ambiguity. Great idea, and love the ternaries for empty strings, much much simpler and easier to understand!
|
@bdukes you think the build failure is a fluke |
|
Yeah, I've re-run the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves on #5242.