-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve HTML attribute support in client resource manager #5244
Improve HTML attribute support in client resource manager #5244
Conversation
Invert if statements where it simplifies logic Use null propagation Consolidate XML comments Fix typos Make static fields readonly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, even cleaner.
I used empty dictionaries so it does not get confused and hit the wrong overload (multiple strings passing nulls), never thought about using the parameter name to resolve that ambiguity. Great idea, and love the ternaries for empty strings, much much simpler and easier to understand!
@bdukes you think the build failure is a fluke |
Yeah, I've re-run the build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
This PR improves on #5242.