Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Node.js HTTP Timeout changes in v13 #25

Closed
jonchurch opened this issue Feb 24, 2020 · 0 comments · Fixed by #26
Closed

Default Node.js HTTP Timeout changes in v13 #25

jonchurch opened this issue Feb 24, 2020 · 0 comments · Fixed by #26
Assignees

Comments

@jonchurch
Copy link
Contributor

jonchurch commented Feb 24, 2020

Hey there! Wanted to file an issue as a heads up that in Node.js v13 there has been a change that alters the default timeout option.

It has been changed from 2 minutes to 0 (which for the HTTP module itself means there will not be a timeout by default).

Your code is using that default timeout, and so when running under Node.js v13 the value will be 0 instead of 120000:

Dnsimple.DEFAULT_TIMEOUT = require('http').createServer().timeout;

I opened a PR to hardcode the value to what it is under all previous Node.js versions (the value has not previously changed since it's introduction in Node.js v0.9.12)

@aeden aeden self-assigned this Feb 24, 2020
weppos pushed a commit that referenced this issue Feb 25, 2020
In Node.js v13 this value has been changed to 0. Hardcoding it to previous value will preserve behavior under Node.js v13.

Closes GH-25
weppos added a commit that referenced this issue Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants