Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode default timeout to 120000 #26

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Hardcode default timeout to 120000 #26

merged 1 commit into from
Feb 25, 2020

Conversation

jonchurch
Copy link
Contributor

In Node.js v13 this value has been changed to 0. Hardcoding it to previous value will preserve behavior under Node.js v13

Closes #25

@aeden aeden assigned aeden and jonchurch and unassigned aeden Feb 24, 2020
@aeden aeden requested review from aeden and weppos February 24, 2020 21:21
@aeden
Copy link
Member

aeden commented Feb 24, 2020

Thank you for the PR @jonchurch. I'll have @weppos look over it in the morning and get it merged in to master.

weppos
weppos approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@weppos weppos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

As a side note, I question 120 seconds being a reasonable default timeout (given our system actually timeouts at a far lower value), but that's outside the scope of this PR which I'll happily merge.

@weppos weppos merged commit 59c84c3 into dnsimple:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weppos weppos weppos approved these changes

@aeden aeden aeden approved these changes

Assignees

@jonchurch jonchurch

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Node.js HTTP Timeout changes in v13
3 participants
@jonchurch @aeden @weppos