This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Fix stack compose bind-mount volumes for Windows #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For stack compose files, use filepath.IsAbs instead of path.IsAbs, for bind-mounted service volumes, because filepath.IsAbs handles Windows paths, while path.IsAbs does not. Signed-off-by: John Stephens <johnstep@docker.com> (cherry picked from commit 9043d39deaa9b8d6b64efd5b4eb0a2225d91dee2)
23 tasks
|
LGTM integration tests and unit tests are green |
docker-jenkins
pushed a commit
that referenced
this pull request
Jul 18, 2018
[18.06] Fix error string in docker CLI test (Windows RS5) Upstream-commit: fe1b4aa5711ed13402ec36b7a0625c27f6e9a846 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 29, 2020
Fix stack compose bind-mount volumes for Windows
docker-jenkins
pushed a commit
that referenced
this pull request
Apr 16, 2021
Installation of yamllint started failing, on non-amd64 builds, which could
be if the version we were using wasn't specific enough about a dependency
to install.
copying Cython/Utility/CppSupport.cpp -> build/lib.linux-aarch64-3.7/Cython/Utility
running build_ext
building 'Cython.Plex.Scanners' extension
creating build/temp.linux-aarch64-3.7
creating build/temp.linux-aarch64-3.7/tmp
creating build/temp.linux-aarch64-3.7/tmp/pip-install-jasgbmp7
creating build/temp.linux-aarch64-3.7/tmp/pip-install-jasgbmp7/Cython
creating build/temp.linux-aarch64-3.7/tmp/pip-install-jasgbmp7/Cython/Cython
creating build/temp.linux-aarch64-3.7/tmp/pip-install-jasgbmp7/Cython/Cython/Plex
aarch64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.7m -c /tmp/pip-install-jasgbmp7/Cython/Cython/Plex/Scanners.c -o build/temp.linux-aarch64-3.7/tmp/pip-install-jasgbmp7/Cython/Cython/Plex/Scanners.o
/tmp/pip-install-jasgbmp7/Cython/Cython/Plex/Scanners.c:21:10: fatal error: Python.h: No such file or directory
#include "Python.h"
^~~~~~~~~~
compilation terminated.
error: command 'aarch64-linux-gnu-gcc' failed with exit status 1
----------------------------------------
Command "/usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-jasgbmp7/Cython/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /tmp/pip-record-if5qclwe/install-record.txt --single-version-externally-managed --prefix /tmp/pip-build-env-_dtiuyfw --compile" failed with error code 1 in /tmp/pip-install-jasgbmp7/Cython/
----------------------------------------
Command "/usr/bin/python3 -m pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-_dtiuyfw --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- setuptools wheel Cython" failed with error code 1 in None
#22 ERROR: executor failed running [/bin/sh -c pip3 install yamllint==1.16.0]: exit code: 1
Trying if updating to the latest version fixes this.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: c35cefb48913fe7a77e99a5b9088cdfccac8ee13
Component: engine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For stack compose files, use filepath.IsAbs instead of path.IsAbs, for
bind-mounted service volumes, because filepath.IsAbs handles Windows
paths, while path.IsAbs does not.
Signed-off-by: John Stephens johnstep@docker.com
(cherry picked from commit 9043d39deaa9b8d6b64efd5b4eb0a2225d91dee2)
Cherry pick of docker/cli#136