Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17.06.0 RC2 tracker #2

Closed
23 tasks done
mavenugo opened this issue May 24, 2017 · 31 comments
Closed
23 tasks done

17.06.0 RC2 tracker #2

mavenugo opened this issue May 24, 2017 · 31 comments

Comments

@mavenugo
Copy link

mavenugo commented May 24, 2017 •
edited by andrewhsu
Loading

STATUS: completed merge list for RC2
@johnstep
Copy link

Configs in stack services are not being included in service specs; fixed by docker/cli#135.

Configs created by stacks are not being removed on service removal; fixed by docker/cli#134.

Neither of these are merged yet, but I strongly suggest we add them. These impact all platforms.

@aaronlehmann
Copy link

Let's try to get some end-to-end testing in place for deploying stacks that use configs.

Formerly this would have been an integration-cli test, but new tests that use the CLI cannot go into moby.

What's the best way to put together such a test?

cc @vdemeester @aluzzardi

@vdemeester
Copy link

moby/moby#33422 should be added too 👼 (cc @thaJeztah @cpuguy83)

@thaJeztah
Copy link
Member

Linking docker/docker-credential-helpers#62, in case we need to keep track of that here as well

/cc @n4ss

@mlaventure
Copy link

moby/moby#33419 is a small change and can happen on systems where containerd is installed separately and started with a wrong configuration. So, I would add it.

@mavenugo
Copy link
Author

@thaJeztah @mlaventure @vdemeester @aaronlehmann @marcusmartins @johnstep I updated all the PRs to the above tracker. Can you pls confirm if all of these are p0 or p1 issues ?
Lets try to avoid adding p2s or lower priority issues to this tracker.

@mlaventure
Copy link

moby/moby#33419 is a P2 if we don't have customers using non official packages 😇

@mlaventure
Copy link

mlaventure commented May 30, 2017 •
edited
Loading

I would categorize docker/cli#79 (the PR that fixes moby/moby#33279) as a P2

@cpuguy83
Copy link
Collaborator

Inclined to say that #33335 is a p1 since "docker kill" will both hang and cause the container to restart if there is a restart policy.
Will have to double check later, but I think it is a regression from 17.03.

@mavenugo
Copy link
Author

Thanks @thaJeztah updated.

@dmp42 @mlaventure @cpuguy83 @andrewhsu I updated the description with priorities and sorted based on PRs that are ready to be cherry-picked and other PRs that are still open.

@cpuguy83
Copy link
Collaborator

Confirming that moby/moby#33376 is needed

@cpuguy83
Copy link
Collaborator

moby/moby#33335 is a bug existing in 17.03 as well. We can call it a P2.

@thaJeztah
Copy link
Member

Discussing with @cpuguy83 - possibly moby/moby#33413 is good to include

@dhiltgen
Copy link

Please consider moby/moby#33330 - UCP makes extensive use of mounting the docker.sock in restart=always containers.

@thaJeztah
Copy link
Member

thaJeztah commented May 31, 2017 •
edited
Loading

Possibly moby/moby#33363, but may not be critical (per the discussion on that issue)

@mlaventure
Copy link

@thaJeztah moby/moby#33363 is a one line change, but I wouldn't categorize it as a P1

@thaJeztah
Copy link
Member

@mlaventure I'm fine skipping it, unless @vieux or @tonistiigi think it's important - was just forwarding the discussion here 😅

@aluzzardi aluzzardi mentioned this issue May 31, 2017
Closed
@thaJeztah
Copy link
Member

From slack: not sure what to do with docker/cli#72 - it fixes a nasty ux issue/regression (see moby/moby#32800, and moby/moby#32556), but it was held up by a discussion about refactoring

@thaJeztah
Copy link
Member

thaJeztah commented Jun 1, 2017 •
edited
Loading

Just opened docker/cli#143 (and moby/moby#33473) which removes the -e / --email flag from docker login, which was scheduled to be removed in 17.06.

@thaJeztah
Copy link
Member

@cpuguy83 this something to consider (if we're focusing on stability)? moby/moby#33472

@cpuguy83
Copy link
Collaborator

cpuguy83 commented Jun 1, 2017 via email

@cyli
Copy link

cyli commented Jun 1, 2017 •
edited
Loading

As a note, I am working on a fix for a bug with external CAs in swarmkit - there's no PR for moby/moby yet for vendoring, but I just wanted to mention it since it's needed for the 17.06 root rotation feature. Will update this comment when I have a PR in moby/moby.

swarmkit PR: moby/swarmkit#2210

@vdemeester
Copy link

@mavenugo @aaronlehmann @thaJeztah I think we should consider docker/cli#144 too 👼

@aluzzardi aluzzardi mentioned this issue Jun 1, 2017
Merged
@mlaventure
Copy link

moby/moby#33500 is needed before GA, it fixes a regression within the builder (see moby/moby#33493).

Basically, ONBUILD doesn't work anymore in 17.06 atm.

@vdemeester
Copy link

I think docker/cli#150 should go in too (labelled it P1 because it really looks like a regression or at least it should not error out)

@aaronlehmann
Copy link

P0 moby/swarmkit#2215

@dnephin
Copy link

dnephin commented Jun 5, 2017

I think we probably want moby/moby#33524 as well

@cyli
Copy link

cyli commented Jun 6, 2017

I'm not sure how to what the cutoff for P0 vs P1 is, but this is either one or the other:
moby/swarmkit#2218

@aaronlehmann
Copy link

Surprised not to see these libnetwork fixes listed here yet:

moby/libnetwork#1786 seems particularly important. It appears to fix broken overlay connectivity in some large-scale setups.

The others are leak fixes.

@mavenugo
Copy link
Author

mavenugo commented Jun 6, 2017

@aaronlehmann yes. these are p1 and seen on high churn systems. We must take these for 17.06. I will update the backlog for RC3.

@andrewhsu andrewhsu changed the title 17.06.0 PR tracker 17.06.0 RC2 tracker Jun 6, 2017
@andrewhsu
Copy link
Contributor

I've moved the backlog to a new issue for tracking 17.06.0 RC3: #8

@vovimayhem vovimayhem mentioned this issue Jun 7, 2017
Closed
@thaJeztah thaJeztah mentioned this issue Jun 7, 2017
Closed
40 tasks
This was referenced Jun 13, 2017
Closed
Closed
@efugier efugier mentioned this issue Apr 15, 2018
Closed
@jaayala jaayala mentioned this issue Oct 10, 2018
Open
3 tasks
@EastZsRoad EastZsRoad mentioned this issue Oct 9, 2019
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests