Set kernel specific config on linux #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fcrisciani IMO this belongs in the overlay driver and as @sanimej suggested it can be in one of the |
|
ok will modify then |
fcrisciani
force-pushed
the
sysctl_gc_thresh
branch
from
b48ce82
to
a59c4dc
Compare
sanimej
reviewed
Jun 2, 2017
drivers/overlay/overlay.go
Outdated
| @@ -188,6 +188,9 @@ func (d *driver) configure() error { | |||
| return d.initializeVxlanIdm() | |||
| } | |||
|
|
|||
| // Apply OS specific kernel configs if needed | |||
| d.once.Do(applyOStweaks) | |||
|
|
|||
There was a problem hiding this comment.
nit: can you change the once variable to something specific, maybe osInitOnce to avoid this getting inadvertently used for some other purpose during the driver init.
LGTM otherwise.
On linux systems bump up gc_thresholds so to lower the probability of running with neighbor table overflow issues Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
fcrisciani
force-pushed
the
sysctl_gc_thresh
branch
from
a59c4dc
to
b23cdc3
Compare
|
Thanks. LGTM |
23 tasks
40 tasks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On linux systems bump up gc_thresholds so to lower the
probability of running with neighbor table overflow issues
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com