17.06.0 RC3 tracker

[andrewhsu]

STATUS: completed merge list for RC3

• [v0.2.x] containerd: ignore SIGPIPE containerd/containerd#930 p1 - Update containerd to cfb82a876ecc11b5ca0977d1733adbe58599088a docker-archive/docker-ce#14 @mlaventure update containerd
• Correct 'go vet' errors containerd/containerd#706 p3 - Update containerd to cfb82a876ecc11b5ca0977d1733adbe58599088a docker-archive/docker-ce#14 @mlaventure update containerd
• add syscall.EPOLL_CLOEXEC containerd/containerd#855 p1 - Update containerd to cfb82a876ecc11b5ca0977d1733adbe58599088a docker-archive/docker-ce#14 @mlaventure update containerd
• Revert ONCLR and OPOST changes moby/moby#33577 p0 - revert Set OPOST on bsd docker-archive/docker-ce#54 fix TTY issues due to RunC change, be sure to reference 33577 (PR should git revert fff42c853aedd3e15c731217058642d9859e7d3f from Set OPOST on bsd docker-archive/docker-ce#25)
• Service alias should not be copied to task alias moby/moby#33578 p0 - Service alias should not be copied to task alias docker-archive/docker-ce#45 Regression introduced in 17.06 (simple cherry-pick PR)
• Bump docker/docker to cd35e4beee13a7c193e2a89008cd87d38fcd0161 cli#166 p0 - revert Set OPOST on bsd docker-archive/docker-ce#54 @thaJeztah fixes the CLI issues of OPOST, be sure to reference 166 (git revert 972de9a65734e146fa4d3b5672b5c7073dd39b1f from Set OPOST on bsd docker-archive/docker-ce#25)
• Enable client side digest pinning for stack deploy cli#121 p1 - [cherry-pick] Enable client side digest pinning for stack deploy docker-archive/docker-ce#44 @aaronlehmann not taking it will cause regression (simple cherry-pick PR) needs special attention for tests updated in Don't resolve image by contacting registry for docker stack deploy tests moby/moby#33386
• Stack deploy fails with 17.06.0-rc1 client against 17.05.0 swarm cli#150 p1 - Handle case of configs on old daemon docker-archive/docker-ce#46 @vdemeester breaks stack deploy on older daemon (simple cherry-pick PR of Handle case of configs on old daemon cli#162 )
• allocator: Fix events watch leak moby/swarmkit#2215 p1 - @cyli [17.06] Re-vendor swarmkit docker-archive/docker-ce#43 revendor swarmkit
• [ca] When rotating the root CA, ignore the node membership moby/swarmkit#2218 p1 - @cyli [17.06] Re-vendor swarmkit docker-archive/docker-ce#43 revendor swarmkit
• orchestrator: Check that service's SpecVersion exists before dereferencing moby/swarmkit#2233 p1 - [17.06] Re-vendor swarmkit docker-archive/docker-ce#43 @cyli @aaronlehmann fixes a crash bug, revendor swarmkit
• Add container environment variables correctly to the health check moby/moby#33249 p1 - Add container environment variables correctly to the health check docker-archive/docker-ce#47 @thaJeztah fixes healthchecks failing in some situations (simple cherry-pick PR)
• Don't create source directory while the daemon is being shutdown, fix #30348 moby/moby#33330 p1 - Don't create source directory while the daemon is being shutdown, fix… docker-archive/docker-ce#48 alleviate possible issues for UCP (simple cherry-pick PR)
• Do not log the CA config CA signing key in debug mode. moby/moby#33464 p1 - Do not log the CA config CA signing key in debug mode. docker-archive/docker-ce#49 @cyli (simple cherry-pick PR)
• [Builder] Fix Cache with ONBUILD moby/moby#33524 p1 - Fix Cache with ONBUILD docker-archive/docker-ce#50 fix builder cache when using ONBUILD (simple cherry-pick PR)
• Fix leak of watchMiss goroutine moby/libnetwork#1786 p1 - need to cherry-pick into https://github.com/docker/libnetwork/tree/bump_17.06.0 and then open PR to bump vendor in components/engine/vendor.conf
• Fix leak of handleTableEvents moby/libnetwork#1787 p1 - same as 1786
• Set kernel specific config on linux moby/libnetwork#1789 p1 - same as 1786
• Vendoring libnetwork and netlink moby/moby#33555 p1 - revendor libnetwork and netlink in engine component docker-archive/docker-ce#55 @mavenugo vendoring libnetwork and netlink into engine related to 1786, 1787, 1789
• Event tests need retry logic moby/moby#33307 p2 - Event tests need to wait for events docker-archive/docker-ce#51 @mavenugo fix flakey DockerSwarmSuite.TestSwarmClusterEventsSecret (simple cherry-pick PR)
• Check signal is unset before using user stopsignal moby/moby#33335 p2 - Check signal is unset before using user stopsignal docker-archive/docker-ce#52 @cpuguy83 to confirm (simple cherry-pick PR)
• libcontainerd: fix reaper goroutine position moby/moby#33419 p2 - libcontainerd: fix reaper goroutine position docker-archive/docker-ce#53 @mlaventure if we don't have customers using non-official packages (simple cherry-pick PR)
• Update golang 1.8.3 cli#173 p1 - Update golang 1.8.3 docker-archive/docker-ce#56 @andrewhsu use golang 1.8.3 instead of golang 1.8.1 for building docker.exe
• docker service ls/ps is not truncating digests anymore cli#79 p1 - [cherry-pick] vendor: Ensure service images get default tag and print familiar strings docker-archive/docker-ce#32 (vendor) @nishanttotla
• docker service ls/ps is not truncating digests anymore cli#79 p1 - Ensure service images get default tag and print familiar strings docker-archive/docker-ce#13 (cherry-pick) @nishanttotla
• Do not reuse a http.Request after a failure in callWithRetry moby/moby#33413 p2 - Do not reuse a http.Request after a failure in callWithRetry docker-archive/docker-ce#57 @thaJeztah discussing with @cpuguy83 17.06.0 RC2 tracker #2 (comment) (simple cherry-pick PR)
• Fix cancelling builder on chunked requests moby/moby#33363 p2 - Fix cancelling builder on chunked requests docker-archive/docker-ce#58 @thaJeztah may not be critical per discussion 17.06.0 RC2 tracker #2 (comment) (simple cherry-pick PR)
• Update deprecated.md for removal of --email flag moby/moby#33473 p3 - Update deprecated.md for removal of --email flag docker-archive/docker-ce#59 @thaJeztah docs updated for email flag deprecation (simple cherry-pick PR)
• Allow --detach and --quiet flags when using --rollback cli#144 p2 - Allow --detach and --quiet flags when using --rollback docker-archive/docker-ce#60 @vdemeester: 17.06.0 RC2 tracker #2 (comment) (simple cherry-pick PR)
• Pass the same log filename to logging plugins on start/stop requests moby/moby#33583 p2 - Logging driver should receive same file in start/stop request docker-archive/docker-ce#61 @cpuguy83 (Inconsistent file path passed to logging plugins on StartLogging/StopLogging moby/moby#33569 (comment)) (simple cherry-pick PR)
• daemon: Remove daemon datastructure dump functionality moby/moby#33598 p1 - daemon: Remove daemon datastructure dump functionality docker-archive/docker-ce#62 @aaronlehmann sending SIGUSR1 to the docker daemon can crash it (simple cherry-pick PR)
• Backport 17.05.0-ce changelog to master moby/moby#33606 p3 - Backport 17.05.0-ce changelog to master docker-archive/docker-ce#63 @thaJeztah add 17.05.0-ce to changelog (simple cherry-pick PR)
• Vendoring libnetwork f4a15a0890383619ad797b3bd2481cc6f46a978d moby/moby#33634 p1 - Vendoring libnetwork 4f5310be349d9299f6cab6d5822312f00cfa965c docker-archive/docker-ce#66 @mavenugo vendor libnetwork
• Remove deprecated -e/--email flag from docker login cli#143 p2 - Remove deprecated -e/--email flag from docker login docker-archive/docker-ce#64 @thaJeztah removes the email flag from docker login, scheduled deprecation in 17.06 (simple cherry-pick PR, also include Remove "-e" / "--email" from integration tests moby/moby#33636)
• backport #29418 "Fix buildIpamResources()" to master moby/moby#33609 p1 - Merge pull request #29418 from aboch/p66 docker-archive/docker-ce#65 missing backport to master, already in 1.13 and 17.03, fixes possible panic (but please confirm @mavenugo ) (simple cherry-pick PR)
• [ca] Validate the Root CA certificate before updating the security config moby/swarmkit#2234 p1 - revendor github.com/docker/swarmkit to ef3c57a docker-archive/docker-ce#69 @cyli
• allocator: Avoid assigning duplicate IPs during initialization moby/swarmkit#2237 p1 - revendor github.com/docker/swarmkit to ef3c57a docker-archive/docker-ce#69 @aaronlehmann allocator: Avoid assigning duplicate IPs during initialization
• [ca/node] Maybe update the root CA when renewing the TLS cert moby/swarmkit#2238 p1 - revendor github.com/docker/swarmkit to ef3c57a docker-archive/docker-ce#69 @cyli
• Disable legacy (v1) registries by default moby/moby#33629 p1 - cherry-pick: Disable legacy (v1) registries by default docker-archive/docker-ce#71 @thaJeztah disable v1 registries by default
• Revert ONCLR and OPOST changes moby/moby#33577 p0 - Revert tty changes docker-archive/docker-ce#70 - @tiborvass

[cyli]

moby/moby#33464 p1 - @cyli to confirm

Yes, p1

[cyli]

Also, the following two swarmkit PRS have been cherry-picked into the swarmkit 17.06 branch already and should also be in rc3:

Update: apologies, I was looking at the wrong branch - that has already made it into rc2 - thanks!

[mlaventure]

would add moby/moby#33456 as a p1

[thaJeztah]

I think there were a couple of PRs left as comment that were not yet added to the checkbox list

[ybalt]

Hi guys, can you please take a look at issue #32195 mentioned by vovimayhem, as it really a showstopper for many people

[skinofstars]

Please consider including docker/cli#150 as it's breaking swarm stack deploy on current release of Mac (17.06) with Cloud (17.05)

[kinghuang]

For docker/cli#150, @vdemeester has a PR at docker/cli#162.

[thaJeztah]

Adding moby/moby#33577, which reverts a breaking change in RunC

[thaJeztah]

Ok, I just went through all the comments on the old issue, checked if they were included in the old issue checklist, then checked if they were included in this issue checklist, and looks like the following suggested PR's / issues didn't make it from the old to the new issue.

(I think we should stick to using a single issue, because this is quite time-consuming, and easy to lose track)

• Don't unmount entire plugin manager tree on remove moby/moby#33422 (17.06.0 RC2 tracker #2 (comment))
• Prevent invalid credentials: no missing server URL or username docker-credential-helpers#62 (17.06.0 RC2 tracker #2 (comment))
• Do not reuse a http.Request after a failure in callWithRetry moby/moby#33413 @thaJeztah: "Discussing with @cpuguy83 - possibly Do not reuse a http.Request after a failure in callWithRetry moby/moby#33413 is good to include" 17.06.0 RC2 tracker #2 (comment)
• Fix cancelling builder on chunked requests moby/moby#33363 @thaJeztah: "Possibly Fix cancelling builder on chunked requests moby/moby#33363, but may not be critical (per the discussion on that issue)" 17.06.0 RC2 tracker #2 (comment)
• Fix prefix-matching for service ps cli#72 @thaJeztah: "it fixes a nasty ux issue/regression (see Fix prefix-matching for service ps moby/moby#32800, and docker servcie ps <service_name> lists all instances of services with names starting with service_name moby/moby#32556)
• Remove deprecated -e/--email flag from docker login cli#143 @thaJeztah: "removes the -e / --email flag from docker login, which was scheduled to be removed in 17.06."
• Update deprecated.md for removal of --email flag moby/moby#33473 @thaJeztah: docs updated for the above
• container/stream/attach: use pools.Copy moby/moby#33472 @thaJeztah: something to consider (if CI is fixed)
• [ca] Fix the UpdateRootCA function to also update the ExternalCA's rootCA moby/swarmkit#2210 @cyli: fix for a bug with external CAs in swarmkit 17.06.0 RC2 tracker #2 (comment)
• Allow --detach and --quiet flags when using --rollback cli#144 @vdemeester: 17.06.0 RC2 tracker #2 (comment)
• Fix ONBUILD COPY moby/moby#33500 @mlaventure: is needed before GA, it fixes a regression within the builder (see ONBUILD COPY fails in 17.06 moby/moby#33493) 17.06.0 RC2 tracker #2 (comment).
• Handle case of configs on old daemon cli#162 p1 @vdemeester: should go in too (labelled it P1 because it really looks like a regression or at least it should not error out) 17.06.0 RC2 tracker #2 (comment)

[thaJeztah]

This one should also be added /cc @Madhu moby/moby#33555 (or a separate PR against docker-ce)

[andrewhsu]

@thaJeztah i've added your list to the backlog section (with some simple editing to shorten the line) so it can get a priority and then move up into the cherry-pick pr list as appropriate, thanks for consolidating

[cyli]

@andrewhsu Can moby/swarmkit#2210 be moved off the backlog because it was merged into the 17.06 branch already? (docker-archive/docker-ce@0efdcc4)

[aaronlehmann]

Sending SIGUSR1 to the docker daemon can crash it. This issue has been showing up in the field. moby/moby#33598 should fix it.

[cyli]

(have opened docker-archive/docker-ce#43 for the swarmkit cherry-picks)

[nishanttotla]

I've opened docker-archive/docker-ce#44 to include cherry-picks related to digest pinning for docker stack deploy (docker/cli#121)

[andrewhsu]

I've updated the list at the top from all comments in this issue thus far. Identified some of the trickier PRs that will need to be created for libnetwork vendoring (with help from @tiborvass ). Need help on prioritization @mavenugo and there seems to be some unfinished issues still open.

[thaJeztah]

docker/cli#143 should be included; it's a deprecation that was postponed already a few times

[thaJeztah]

@mavenugo tentatively adding moby/moby#33609, which was not backported to master, but is part of 1.13 / 17.03, and fixes a possible panic (but please verify)

[mavenugo]

@thaJeztah Good catch and agreed. I will spend some time this morning to review the pending PRs in the list.

[aaronlehmann]

Let's also include moby/swarmkit#2233. This fixes a crash bug.

[aaronlehmann]

Nominating moby/swarmkit#2237, which is related to a defect in the allocator that causes it to assign duplicate IPs.

[thaJeztah]

@mavenugo @andrewhsu @aaronlehmann we need moby/moby#33629 as well; the deprecation plan was to disable v1 registries by default in 17.06, so that users have enough time to migrate their legacy registries in time for support them being removed in v17.12

[mavenugo]

@aaronlehmann moby/swarmkit#2233 is cherry-picked. Once moby/swarmkit#2237 is in swarmkit master, can you pls chery-pick into swarmkit 1706 bump branch and open a PR in docker-ce ?

I added this PR to the tracking list above.

[vdemeester]

@mavenugo docker/cli#180 should be included too (fixing in docker/cli#182)

[cyli]

I'd also like to include: moby/swarmkit#2234 and moby/swarmkit#2238, since they help resolve edge cases when there's a demotion during CA rotation.

[aaronlehmann]

I've opened docker-archive/docker-ce#67 for moby/swarmkit#2237.

@cyli could you please cherry-pick those two fixes, then I'll update docker-archive/docker-ce#67 ?

[thaJeztah]

moby/moby#33472 was merged, so should be ready for cherry-picking if we want it

[unclejack]

Is there something I could do to make sure moby/moby#33472 gets cherry-picked for the release?

[aaronlehmann]

I know RC3 is already out, but I don't know where else to track this (I agree with @thaJeztah that having a separate issue for each RC is a little tough).

I opened docker-archive/docker-ce#75 for moby/swarmkit#2244.

[andrewhsu]

I've moved the backlog to a new issue for tracking 17.06.0 RC4: #14

@aaronlehmann @thaJeztah having a new issue for each RC helps me in managing a smaller list of PRs. Plus, the ticket that is referenced by the tracking issue says the RC release it is tracked in. Willing to discuss a better procedure or use of a better tool to track issues across different repos for the 17.07 release.