Backport fix to 17.03 #1784
Merged
Backport fix to 17.03 #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stacktrace related to 17.03: Stacktrace related in 17.03: |
|
Not ready yet, looks like there is still something missing to handle the stacktrace reported above |
|
I'm confused - is the problem with the backport, or is the stack trace in #1784 (comment) unrelated to what was fixed here? |
|
@aaronlehmann sorry for the confusion, but I will group here all the backports for all the fixes for the goroutine leaks.
|
|
Wait for the master one to be reviewed and accepted: |
added 5 commits
June 9, 2017 15:49
Fixed cancelling method call to avoid go routine leaks Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
The channel ch.C is never closed. Added the listen of the ch.Done() to guarantee that the goroutine is exiting once the event channel is closed Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
On linux systems bump up gc_thresholds so to lower the probability of running with neighbor table overflow issues Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
The netlink socket that was used to monitor the L2 miss was never being closed. The watchMiss goroutine spawned was never returning. This was causing goroutine leak in case of createNetwork/destroyNetwork Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
The feature was not getting properly triggered, move it as first operation in the configure Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed cancelling method call to avoid go routine leaks
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com