Removing the override for ipamdriver for local scope networks in #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit contains fix for the issue reported in moby/moby#33415 and moby#1772. With the feature introduced to support local scope networks in swarm mode the network configuration to include ipam driver was overriden in libnetwork. This has been removed with this fix which will allow ipam-driver option to be used for task allocation Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
|
LGTM |
|
@eyz yes. this need to be vendored into moby |
|
Thanks. I updated the moby/moby#33415 issue with the next action. |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit contains fix for the issue reported in moby/moby#33415 and
#1772. With the feature introduced to support local scope networks in swarm mode (moby/moby#32981) the network configuration to include ipam driver was over-riden in libnetwork. This has been removed with this fix which will allow ipam-driver option to be used for task allocation.
Verified with the steps posted in the issue #1772 as well.
Signed-off-by: Abhinandan Prativadi abhi@docker.com