Include stack service configs in service specs #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Signed-off-by: John Stephens <johnstep@docker.com>
johnstep
force-pushed
the
fix_stack_service_configs
branch
from
8b8c64e
to
b7cac96
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 44.82% 44.82% -0.01%
==========================================
Files 169 169
Lines 11360 11361 +1
==========================================
Hits 5092 5092
- Misses 5978 5979 +1
Partials 290 290 |
johnstep
changed the title
|
Do we have a unit test for |
|
There isn't currently, but it should be possible to write one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Stephens johnstep@docker.com