Import man docs completion

[tiborvass]

This partially replaces #68.

ca8303e is the merge commit that imports the changes
d2cb97e and 875daf0 and d2976d5 are additional commits.

$ git checkout f888a25ff5     # engine commit used in docker-ce in 17.06 branch
$ git filter-branch -f -d /tmp/fb  --index-filter "git rm --cached -qr --ignore-unmatch -- . && git reset -q \$GIT_COMMIT -- $(echo experimental man docs/{README.md,deprecated.md,extend} docs/sources/experimental docs/{sources/,}reference/{glossary.md,builder.md,builder.rst,index.md,index.rst,run.md,run.rst,commandline} contrib/completion docs/yaml)" --prune-empty
$ git rebase -Xours --root HEAD
$ git rm man/docker-volume.1.md && git rebase --continue
$ git rm docs/deprecated.md && git rebase --continue
$ git branch -f tmp
$ git checkout 3dfb8343b139d6342acfd9975d7f1068b5b1c3d3   # cli commit used in docker-ce in 17.06 branch
$ git merge --allow-unrelated-histories tmp
$ git revert -e $(git log --format=%H -1 --follow -- docs/yaml)
$ # ... add the additional commits

Please note that this imports only up till what is in 17.06. The rest will be imported in another PR. This is so that it is easier to include this PR in the release branch of the docker-ce repo.

A follow up PR is also needed to change Makefiles and add scripts to generate both man pages and yaml docs. The reason it will be separate is because cli master and cli 17.06 have diverged for those.

[andrewhsu]

Datapoint for expected number of files in man directories from docker-ce 17.05.0:

$ rpm -ql docker-ce-17.05.0.ce | grep /usr/share/man/man1 | wc -l
151
$ rpm -ql docker-ce-17.05.0.ce | grep /usr/share/man/man5 | wc -l
2
$ rpm -ql docker-ce-17.05.0.ce | grep /usr/share/man/man8 | wc -l
1

[dnephin]

@tiborvass Ci was failing because of imports. I forced pushed a commit to this branch with the following changes:

• dropped the commit which excluded these scripts from linting
• add missing dependencies to vendor (it's only 3 files, we may as well add them)
• fixed the imports in both files (your commit only fixed one, and I think it was dropped somehow, because I didn't see the commit you referenced in the description in this PR)

Edit: actually we might be missing github.com/cpuguy83/go-md2man/md2man but lint passes for now, so I think we can worry about it when we add the tasks to generate these docs.

Edit2: actually we need it for unit tests, so adding it

[dnephin]

If you haven't started on the Makefile/scripts for running these generations, let me know. I can open a PR to add them.

[dnephin]

I pushed another commit that removes the old man/Dockerfile and man/glide.*. We shouldn't need either of these anymore.

LGTM

[andrewhsu]

As of d2976d5 I see code changed in the cli dir that are not strictly comments or documentation file related:

$ git diff --stat master tv/import-man-docs-completion | grep '^ cli'
 cli/command/container/attach.go                    |   38 +-
 cli/command/registry.go                            |    4 +-
 cli/command/registry/login.go                      |    4 +
 cli/command/registry_test.go                       |   79 -
 cli/command/service/opts.go                        |   62 +-
 cli/command/service/opts_test.go                   |   27 +-
 cli/command/service/update.go                      |   10 +-
 cli/command/stack/client_test.go                   |   37 -
 cli/command/stack/common.go                        |   10 -
 cli/command/stack/deploy_composefile.go            |   30 +-
 cli/command/stack/deploy_composefile_test.go       |   57 -
 cli/command/stack/remove.go                        |   23 +-
 cli/command/stack/remove_test.go                   |   19 -
 cli/command/system/prune.go                        |   19 +-
 cli/compose/convert/service.go                     |   13 +-
 cli/compose/loader/loader.go                       |   20 +-
 cli/internal/test/network/client.go                |   56 -

For example:

$ git diff master tv/import-man-docs-completion -- cli/command/registry.go
diff --git a/cli/command/registry.go b/cli/command/registry.go
index 802b3a4b8..884fa6ec4 100644
--- a/cli/command/registry.go
+++ b/cli/command/registry.go
@@ -28,9 +28,7 @@ func ElectAuthServer(ctx context.Context, cli Cli) string {
        // the default registry URL might be Windows specific.
        serverAddress := registry.IndexServer
        if info, err := cli.Client().Info(ctx); err != nil {
-               fmt.Fprintf(cli.Err(), "Warning: failed to get default registry endpoint from daemon (%v). Using system default: %s\n", err, serverAddress)
-       } else if info.IndexServerAddress == "" {
-               fmt.Fprintf(cli.Err(), "Warning: Empty registry endpoint from daemon. Using system default: %s\n", serverAddress)
+               fmt.Fprintf(cli.Out(), "Warning: failed to get default registry endpoint from daemon (%v). Using system default: %s\n", err, serverAddress)
        } else {
                serverAddress = info.IndexServerAddress
        }

Are these pulled in because of the associated man-page related commits and are they desirable?

[dnephin]

@andrewhsu I was looking at that same diff until I realized my error. The problem is you're diffing against master, not 3dfb834. This was branched from 3dfb834. So the diff you're seeing is the inverse diff of changes on master that are not in this branch.

[andrewhsu]

@dnephin cool, thanks for pointing that out. diff now looks good on that front:

$ git diff --stat 3dfb834 tv/import-man-docs-completion | grep '^ cli' # no changes to golang code in cli which is good

[tiborvass]

@dnephin About vendor.conf change, I was thinking of not adding it in the main dockerfile, since it's not needed for the cli, just for the man pages. But I don't mind if it's fine for you.

LGTM

[vieux]

LGTM let's merge this soon before it diverges too much.