Add 1.22rc1 #500
Merged
Add 1.22rc1 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Go 1.22 and later requires Go 1.20 as the bootstrap toolchain.doh, I didn't realize they'd bumped the baseline all the way to Go 1.20 already 😭 Edit: ref: golang/go#54265 -- also, that means 1.24 will require 1.22, so this will get worse/harder over time, not easier |
|
After reviewing the details (and how "ouroboros" it would be to solve this "properly", especially in the face of the long-term implications of golang/go#54265), my updated proposal is that we effectively revert #335 for 1.21+ -- as of Go 1.21, the only architecture we actually build from source across all our supported variants/distributions is arm32v5 (Debian's The only suggestion of actual arm32v5 users I've managed to find is #263, which is someone on one of the older Raspberry Pi devices (which are technically armv6) wanting to use a Debian-based image -- as of 1.21, the Alpine images are using the exact same upstream-provided pre-compiled binaries, so suggesting that those users switch to Alpine's arm32v6 images instead is extremely reasonable. I will be updating this shortly. |
> After reviewing the details (and how "ouroboros" it would be to solve this "properly", especially in the face of the long-term implications of https://golang.org/issues/54265), my updated proposal is that we effectively revert 11eef5d for 1.21+ -- as of Go 1.21, the _only_ architecture we actually build from source across _all_ our supported variants/distributions is arm32v5 (Debian's `armel`) because Go's published `arm` binaries are explicitly `v6` (see also 40db26d). > > The only suggestion of actual arm32v5 users I've managed to find is someone on one of the older Raspberry Pi devices (which are technically armv6) wanting to use a Debian-based image -- as of 1.21, the Alpine images are using the exact same upstream-provided pre-compiled binaries, so suggesting that those users switch to Alpine's arm32v6 images instead is extremely reasonable.
Diff:$ diff -u <(bashbrew cat golang) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63 2023-12-19 15:34:14.147333988 -0800
+++ /dev/fd/62 2023-12-19 15:34:14.135333892 -0800
@@ -1,25 +1,74 @@
Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon), Joseph Ferguson <yosifkit@gmail.com> (@yosifkit), Johan Euphrosine <proppy@google.com> (@proppy)
GitRepo: https://github.com/docker-library/golang.git
+Tags: 1.22rc1-bookworm, 1.22-rc-bookworm
+SharedTags: 1.22rc1, 1.22-rc
+Architectures: amd64, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
+Directory: 1.22-rc/bookworm
+
+Tags: 1.22rc1-bullseye, 1.22-rc-bullseye
+Architectures: amd64, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
+Directory: 1.22-rc/bullseye
+
+Tags: 1.22rc1-alpine3.19, 1.22-rc-alpine3.19, 1.22rc1-alpine, 1.22-rc-alpine
+Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
+Directory: 1.22-rc/alpine3.19
+
+Tags: 1.22rc1-alpine3.18, 1.22-rc-alpine3.18
+Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
+Directory: 1.22-rc/alpine3.18
+
+Tags: 1.22rc1-windowsservercore-ltsc2022, 1.22-rc-windowsservercore-ltsc2022
+SharedTags: 1.22rc1-windowsservercore, 1.22-rc-windowsservercore, 1.22rc1, 1.22-rc
+Architectures: windows-amd64
+GitCommit: 46d44c197aa3ce81c16ad43a2e4b331cc188053a
+Directory: 1.22-rc/windows/windowsservercore-ltsc2022
+Constraints: windowsservercore-ltsc2022
+
+Tags: 1.22rc1-windowsservercore-1809, 1.22-rc-windowsservercore-1809
+SharedTags: 1.22rc1-windowsservercore, 1.22-rc-windowsservercore, 1.22rc1, 1.22-rc
+Architectures: windows-amd64
+GitCommit: 46d44c197aa3ce81c16ad43a2e4b331cc188053a
+Directory: 1.22-rc/windows/windowsservercore-1809
+Constraints: windowsservercore-1809
+
+Tags: 1.22rc1-nanoserver-ltsc2022, 1.22-rc-nanoserver-ltsc2022
+SharedTags: 1.22rc1-nanoserver, 1.22-rc-nanoserver
+Architectures: windows-amd64
+GitCommit: 46d44c197aa3ce81c16ad43a2e4b331cc188053a
+Directory: 1.22-rc/windows/nanoserver-ltsc2022
+Constraints: nanoserver-ltsc2022, windowsservercore-ltsc2022
+
+Tags: 1.22rc1-nanoserver-1809, 1.22-rc-nanoserver-1809
+SharedTags: 1.22rc1-nanoserver, 1.22-rc-nanoserver
+Architectures: windows-amd64
+GitCommit: 46d44c197aa3ce81c16ad43a2e4b331cc188053a
+Directory: 1.22-rc/windows/nanoserver-1809
+Constraints: nanoserver-1809, windowsservercore-1809
+
Tags: 1.21.5-bookworm, 1.21-bookworm, 1-bookworm, bookworm
SharedTags: 1.21.5, 1.21, 1, latest
-Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
-GitCommit: 40db26d6cc395e12ec499d7d88c77ee5f6dbe912
+Architectures: amd64, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
Directory: 1.21/bookworm
Tags: 1.21.5-bullseye, 1.21-bullseye, 1-bullseye, bullseye
-Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
-GitCommit: 40db26d6cc395e12ec499d7d88c77ee5f6dbe912
+Architectures: amd64, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
Directory: 1.21/bullseye
Tags: 1.21.5-alpine3.19, 1.21-alpine3.19, 1-alpine3.19, alpine3.19, 1.21.5-alpine, 1.21-alpine, 1-alpine, alpine
Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 40db26d6cc395e12ec499d7d88c77ee5f6dbe912
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
Directory: 1.21/alpine3.19
Tags: 1.21.5-alpine3.18, 1.21-alpine3.18, 1-alpine3.18, alpine3.18
Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 40db26d6cc395e12ec499d7d88c77ee5f6dbe912
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
Directory: 1.21/alpine3.18
Tags: 1.21.5-windowsservercore-ltsc2022, 1.21-windowsservercore-ltsc2022, 1-windowsservercore-ltsc2022, windowsservercore-ltsc2022
@@ -63,12 +112,12 @@
Tags: 1.20.12-alpine3.19, 1.20-alpine3.19, 1.20.12-alpine, 1.20-alpine
Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 84f47a944aa3d10104ad45dd8a188b878595cac4
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
Directory: 1.20/alpine3.19
Tags: 1.20.12-alpine3.18, 1.20-alpine3.18
Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 339da23255a9dc00f7921fca9a022f6b95843358
+GitCommit: 8188fe464dc344c8ac20cad12cf80e65f452af93
Directory: 1.20/alpine3.18
Tags: 1.20.12-windowsservercore-ltsc2022, 1.20-windowsservercore-ltsc2022 |
yosifkit
approved these changes
Dec 20, 2023
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 20, 2023
Changes: - docker-library/golang@fc56cbc: Merge pull request docker-library/golang#500 from infosiftr/go1.22rc1 - docker-library/golang@8188fe4: Stop (ever) building from source for 1.21+ - docker-library/golang@46d44c1: Add 1.22rc1 - docker-library/golang@3a0fd1f: Update GHA YAML with bashbrew example improvements (esp. concurrency:) - docker-library/golang@020b04e: Update "munge.sh" (we need to force build on Alpine now and Buster does not exist)
Open
Merged
martin-g
pushed a commit
to martin-g/docker-official-images
that referenced
this pull request
Apr 3, 2024
Changes: - docker-library/golang@fc56cbc: Merge pull request docker-library/golang#500 from infosiftr/go1.22rc1 - docker-library/golang@8188fe4: Stop (ever) building from source for 1.21+ - docker-library/golang@46d44c1: Add 1.22rc1 - docker-library/golang@3a0fd1f: Update GHA YAML with bashbrew example improvements (esp. concurrency:) - docker-library/golang@020b04e: Update "munge.sh" (we need to force build on Alpine now and Buster does not exist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.