-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add secret-envs input #980
Conversation
@crazy-max bumped the toolkit to the rc ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you forgot to run docker buildx bake pre-checkin
.
Also can you add a test in
describe('getArgs', () => { |
I was also wondering if we should check for secret id collision but can be a follow-up.
I added some tests that passed here: https://github.com/docker/build-push-action/pull/980/files#diff-35112c3ed4be2816f18f19320c9c2e1fd2d10fede1dbd6ee023d75fe963ea722R622-R664 not sure if they are enough though. Also baked it as you said :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing input in action.yml
.
Also squash your commits similar to https://github.com/docker/build-push-action/pull/957/commits. Thanks.
Not sure what you mean with the missing input as it is added here: Lines 83 to 85 in 4a0c05c
I will squash the commits :) |
Sorry I'm blind 😅
🙏 |
There we go, hope it's good! |
Sorry for the misunderstanding but I was expected two commits:
I have renamed your PR title so we are aligned. |
Signed-off-by: Elias Lundgren <145569914+elias-lundgren@users.noreply.github.com>
Signed-off-by: Elias Lundgren <145569914+elias-lundgren@users.noreply.github.com>
No worries! Hopefully it's right this time. The actions-toolkit is still on the rc.1, just wanted that known :) |
Yes that's fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you! |
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://github.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://github.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@​crazy-max](https://github.com/crazy-max) in [docker/build-push-action#992 - Add `secret-envs` input by [@​elias-lundgren](https://github.com/elias-lundgren) in [docker/build-push-action#980 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.17.3 to 7.23.2 by [@​dependabot](https://github.com/dependabot) in [docker/build-push-action#991 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [docker/build-push-action#990 [docker/build-push-action#1006 **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://github.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://github.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@​crazy-max](https://github.com/crazy-max) in [docker/build-push-action#992 - Add `secret-envs` input by [@​elias-lundgren](https://github.com/elias-lundgren) in [docker/build-push-action#980 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.17.3 to 7.23.2 by [@​dependabot](https://github.com/dependabot) in [docker/build-push-action#991 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [docker/build-push-action#990 [docker/build-push-action#1006 **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Mogyuchi/gh-test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://github.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://github.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@​crazy-max](https://github.com/crazy-max) in [docker/build-push-action#992 - Add `secret-envs` input by [@​elias-lundgren](https://github.com/elias-lundgren) in [docker/build-push-action#980 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.17.3 to 7.23.2 in [docker/build-push-action#991 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [docker/build-push-action#990 [docker/build-push-action#1006 **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Rapporteket/docker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
how exactly does this differ from |
@bendavies the
|
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://github.com/actions/checkout) | action | minor | `v4.0.0` -> `v4.1.1` | | [docker/build-push-action](https://github.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4.1.1`](https://github.com/actions/checkout/releases/tag/v4.1.1) [Compare Source](https://github.com/actions/checkout/compare/v4.1.0...v4.1.1) ##### What's Changed - Update CODEOWNERS to Launch team by [@​joshmgross](https://github.com/joshmgross) in [actions/checkout#1510 - Correct link to GitHub Docs by [@​peterbe](https://github.com/peterbe) in [actions/checkout#1511 - Link to release page from what's new section by [@​cory-miller](https://github.com/cory-miller) in [actions/checkout#1514 ##### New Contributors - [@​joshmgross](https://github.com/joshmgross) made their first contribution in [actions/checkout#1510 - [@​peterbe](https://github.com/peterbe) made their first contribution in [actions/checkout#1511 **Full Changelog**: actions/checkout@v4.1.0...v4.1.1 ### [`v4.1.0`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v410) [Compare Source](https://github.com/actions/checkout/compare/v4.0.0...v4.1.0) - [Add support for partial checkout filters](https://github.com/actions/checkout/pull/1396) </details> <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://github.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@​crazy-max](https://github.com/crazy-max) in [docker/build-push-action#992 - Add `secret-envs` input by [@​elias-lundgren](https://github.com/elias-lundgren) in [docker/build-push-action#980 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.17.3 to 7.23.2 in [docker/build-push-action#991 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [docker/build-push-action#990 [docker/build-push-action#1006 **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/naa0yama/OpenWrt-FortiGate-50E-custom-image). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Makes use of implementation in docker/actions-toolkit@a1ffbe9 and the fix in docker/actions-toolkit#176.
A new version of the npm package (@docker/actions-toolkit) with the fix implemented in the pull request has to be released before this can be merged as I understand it.
That version should be bumped in package-lock.json/package.json as well but I don't know if dependabot or me should do it.