-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add annotations input #992
Conversation
f0280bd
to
a0bf22b
Compare
Close #958. (Will my keyword works?) EDIT: it doesn't seem to work... but anyway that might be the issue that should be closed along with this PR. |
a0bf22b
to
662cd77
Compare
await Util.asyncForEach(inputs.annotations, async annotation => { | ||
args.push('--annotation', annotation); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad that there's a version checking. Could we give an error in an else branch, saying it's not supported?
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
7e8a65e
to
c66ae3a
Compare
@@ -217,6 +217,7 @@ Following inputs can be used as `step.with` keys | |||
|--------------------|-------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| `add-hosts` | List/CSV | List of [customs host-to-IP mapping](https://docs.docker.com/engine/reference/commandline/build/#add-entries-to-container-hosts-file---add-host) (e.g., `docker:10.180.0.1`) | | |||
| `allow` | List/CSV | List of [extra privileged entitlement](https://docs.docker.com/engine/reference/commandline/buildx_build/#allow) (e.g., `network.host,security.insecure`) | | |||
| `annotations` | List | List of annotation to set to the image | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get some more examples of what is the expected format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvdksn Like other examples we have in https://docs.docker.com/build/ci/github-actions/ it might good to have one for annotations as suggested by @tonistiigi. Same in https://github.com/docker/buildx/blob/master/docs/reference/buildx_build.md for --annotation
flag. Let me know if you need help about the syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 sgtm, we only have it mentioned in the exporter docs currently I think
https://docs.docker.com/build/exporters/image-registry/#annotations
https://docs.docker.com/build/exporters/oci-docker/#annotations
@crazy-max @tonistiigi Hi, as an outsider I feel the PR might not be ready for merging. It seems to have two outstanding issues: (1) the CI was testing "v0.12.0-rc1" not the latest version, which doesn't seem to be normal, and (2) it will silently ignore annotations when buildx is too old. Of course, we can fix these in another PR, but I found the merge a bit strange given these issues. I'll be happy to learn that I'm wrong. Anyway, thank you for moving forward on this issue quickly. 😀 |
Yes we are going to open a follow-up here to update to latest when Buildx 0.12.0 is GA this week. We have done this quite often when adding new inputs like |
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://github.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://github.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@​crazy-max](https://github.com/crazy-max) in [docker/build-push-action#992 - Add `secret-envs` input by [@​elias-lundgren](https://github.com/elias-lundgren) in [docker/build-push-action#980 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.17.3 to 7.23.2 by [@​dependabot](https://github.com/dependabot) in [docker/build-push-action#991 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [docker/build-push-action#990 [docker/build-push-action#1006 **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://github.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://github.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@​crazy-max](https://github.com/crazy-max) in [docker/build-push-action#992 - Add `secret-envs` input by [@​elias-lundgren](https://github.com/elias-lundgren) in [docker/build-push-action#980 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.17.3 to 7.23.2 by [@​dependabot](https://github.com/dependabot) in [docker/build-push-action#991 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [docker/build-push-action#990 [docker/build-push-action#1006 **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Mogyuchi/gh-test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://github.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://github.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@​crazy-max](https://github.com/crazy-max) in [docker/build-push-action#992 - Add `secret-envs` input by [@​elias-lundgren](https://github.com/elias-lundgren) in [docker/build-push-action#980 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.17.3 to 7.23.2 in [docker/build-push-action#991 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [docker/build-push-action#990 [docker/build-push-action#1006 **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Rapporteket/docker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://github.com/actions/checkout) | action | minor | `v4.0.0` -> `v4.1.1` | | [docker/build-push-action](https://github.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4.1.1`](https://github.com/actions/checkout/releases/tag/v4.1.1) [Compare Source](https://github.com/actions/checkout/compare/v4.1.0...v4.1.1) ##### What's Changed - Update CODEOWNERS to Launch team by [@​joshmgross](https://github.com/joshmgross) in [actions/checkout#1510 - Correct link to GitHub Docs by [@​peterbe](https://github.com/peterbe) in [actions/checkout#1511 - Link to release page from what's new section by [@​cory-miller](https://github.com/cory-miller) in [actions/checkout#1514 ##### New Contributors - [@​joshmgross](https://github.com/joshmgross) made their first contribution in [actions/checkout#1510 - [@​peterbe](https://github.com/peterbe) made their first contribution in [actions/checkout#1511 **Full Changelog**: actions/checkout@v4.1.0...v4.1.1 ### [`v4.1.0`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v410) [Compare Source](https://github.com/actions/checkout/compare/v4.0.0...v4.1.0) - [Add support for partial checkout filters](https://github.com/actions/checkout/pull/1396) </details> <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://github.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://github.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@​crazy-max](https://github.com/crazy-max) in [docker/build-push-action#992 - Add `secret-envs` input by [@​elias-lundgren](https://github.com/elias-lundgren) in [docker/build-push-action#980 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.17.3 to 7.23.2 in [docker/build-push-action#991 - Bump [@​docker/actions-toolkit](https://github.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [docker/build-push-action#990 [docker/build-push-action#1006 **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/naa0yama/OpenWrt-FortiGate-50E-custom-image). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
follow-up docker/buildx#2020
fixes #958