Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubernetes] Support --config to mount buildkit.toml and -driver-opt=qemu.install=true,qemu.image=tonistiigi/binfmt:latest for qemu installing #682

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[kubernetes] Support --config to mount buildkit.toml and -driver-opt=qemu.install=true,qemu.image=tonistiigi/binfmt:latest for qemu installing #682

merged 1 commit into from
Aug 10, 2021

Conversation

morlay
Copy link
Collaborator

@morlay morlay commented Jul 21, 2021

fix #603

morlay
morlay commented Jul 21, 2021
View reviewed changes
go.mod
@@ -1,6 +1,6 @@
module github.com/docker/buildx

go 1.13
go 1.16
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.ReadFile required

@morlay morlay force-pushed the k8s-enhance branch 2 times, most recently from 33fc205 to 8c1fb43 Compare July 21, 2021 03:02
@morlay
Copy link
Collaborator Author

morlay commented Jul 21, 2021

Is master branch broken?
Not sure why I have to updates vendor and go{.mod,.sum}

@morlay morlay requested review from tonistiigi and AkihiroSuda July 21, 2021 03:06
@tonistiigi
Copy link
Member

Not sure why I have to updates vendor and go{.mod,.sum}

Because of the version change probably.

tonistiigi
tonistiigi approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 👍

PTAL @AkihiroSuda

@morlay
Copy link
Collaborator Author

morlay commented Jul 21, 2021

@tonistiigi I added docs to fix #516 too.

Now sure the docs should be here

@morlay morlay force-pushed the k8s-enhance branch 2 times, most recently from 58f184f to 05d6724 Compare July 21, 2021 04:44
@AkihiroSuda AkihiroSuda changed the title Support --config to mount buildkit.toml and -driver-opt=withqemu=true,qemuimage=tonistiigi/binfmt:latest for qemu installing [kubernetes] Support --config to mount buildkit.toml and -driver-opt=withqemu=true,qemuimage=tonistiigi/binfmt:latest for qemu installing Jul 21, 2021
@AkihiroSuda
Copy link
Collaborator

Support --config to mount buildkit.toml and -driver-opt=withqemu=true,qemuimage=tonistiigi/binfmt:latest for qemu installing #682

This PR seems mixing up two different topics.

Next time please consider splitting PRs (or splitting commits) .

@morlay morlay changed the title [kubernetes] Support --config to mount buildkit.toml and -driver-opt=withqemu=true,qemuimage=tonistiigi/binfmt:latest for qemu installing [kubernetes] Support --config to mount buildkit.toml and -driver-opt=qemu.install=true,qemu.image=tonistiigi/binfmt:latest for qemu installing Jul 21, 2021
@morlay morlay force-pushed the k8s-enhance branch 2 times, most recently from b79b9af to bf24485 Compare July 21, 2021 05:36
@morlay
Copy link
Collaborator Author

morlay commented Jul 21, 2021 •
edited
Loading

@AkihiroSuda I removed the doc from this PR.

May just put in issues or discussions.
Now move to https://gist.github.com/morlay/e9d47919c3a168c7e3a2659788532be9

I don't know where to put those info.

@morlay morlay mentioned this pull request Jul 21, 2021
Closed
@morlay
Copy link
Collaborator Author

morlay commented Jul 21, 2021 •
edited
Loading

docs mv to #685

AkihiroSuda
AkihiroSuda approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have CI, but can be added later

@morlay
Copy link
Collaborator Author

morlay commented Jul 24, 2021

Yes. Could setup k3s for kubernetes.
but i have no idea how to the testing scripts though go or just prue shells

      - name: setup k3s
        run: |
          curl -sfL https://get.k3s.io | K3S_KUBECONFIG_MODE="644" sh -s -
          kubectl version
      - run: #scrips
        env:
          KUBECONFIG: /etc/rancher/k3s/k3s.yaml

@morlay morlay mentioned this pull request Jul 24, 2021
Closed
@morlay morlay mentioned this pull request Aug 4, 2021
Closed
@tonistiigi tonistiigi merged commit 06367a1 into docker:master Aug 10, 2021
@onmomo
Copy link

onmomo commented Sep 3, 2021

This great feature is now merged for quite some time but is not yet included in the latest buildx releases. Is this on purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
area/driver/kubernetes kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is --config ignored when using the k8s driver
4 participants
@morlay @tonistiigi @AkihiroSuda @onmomo