Setup integration testing #691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morlay <morlay.null@gmail.com>
morlay
force-pushed
the
setup-integration-testing
branch
from
1fd95a8 to
6c704ac
Compare
AkihiroSuda
reviewed
Jul 28, 2021
| @@ -0,0 +1,19 @@ | |||
| #!/bin/bash | |||
|
|
|||
|
Maybe as a stopgap we could start with this but generally I would prefer buildkit-style integration testing with dockerfile describing the environment. Not github actions specific scripts that will have scaling issues. |
crazy-max
reviewed
Sep 8, 2021
There was a problem hiding this comment.
Like @tonistiigi said it would be better to sandbox as much as possible to be able to repro locally.
| @@ -0,0 +1,60 @@ | |||
| name: testing-builder | |||
|
|
|||
| on: push | |||
There was a problem hiding this comment.
Suggested change
| on: push | |
| on: | |
| workflow_dispatch: | |
| push: | |
| branches: | |
| - 'master' | |
| - 'v[0-9]*' | |
| pull_request: | |
| branches: | |
| - 'master' | |
| - 'v[0-9]*' |
We should trigger on pr and release branches.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Morlay morlay.null@gmail.com
driver (
docker-container,kubernetes) X mode (single-node,multi-nodes)could added
--configmode, but block by #682To run cases:
https://github.com/morlay/buildx/actions/runs/1062152109