Bump Go to 1.11.1 #1426
Merged
Bump Go to 1.11.1 #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
go111-pr1316
branch
2 times, most recently
from
6920a85
to
ef303e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1426 +/- ##
=======================================
Coverage 54.22% 54.22%
=======================================
Files 289 289
Lines 19359 19359
=======================================
Hits 10498 10498
Misses 8185 8185
Partials 676 676 |
|
Changes to osx build env separated out to docker/golang-cross#11 where they belong. Once the image will be available I will remove those from the last commit. |
Fix this warning from go-1.11 > cli/registry/client/fetcher.go:234: Debugf format %s has arg > repoEndpoint of wrong type client.repositoryEndpoint Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In case go build will see a need to call C++ (rather than C) compiler, CXX env var need to be properly set (to osxcross wrapper). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Release notes: https://golang.org/doc/devel/release.html#go1.11 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
gofmt/goimports changed some heuristics in 1.11 and the code is now formatted slightly differently. No functional change, just whitespace. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
go111-pr1316
branch
from
ef303e1
to
906c2d1
Compare
|
OK this once it ready for merge once CI is all green |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1316 (see the comments in there to find out how I came to a solution), a switch to Go 1.11.1.
Most complicated part was docker/golang-cross#11