[18.09 backport] bump Golang 1.11.11, and some makefile improvements #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 18.09 #1709 +/- ##
=======================================
Coverage 54.23% 54.23%
=======================================
Files 290 290
Lines 19428 19428
=======================================
Hits 10537 10537
Misses 8212 8212
Partials 679 679 |
thaJeztah
changed the title
need to rebase to get #1729 |
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
44dfcf6
to
0a6422b
Compare
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
0a6422b
to
2e6a04f
Compare
|
fwiw; discussed this with @andrewhsu, and given that this is not critical, and changes in other repos will have to be made as well, we'll skip this for the 18.09.5 release, but will include it in 18.09.6, so don't merge yet |
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
2 times, most recently
from
74b32fa
to
7fac617
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
7fac617
to
b344d48
Compare
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
b344d48
to
c6060b4
Compare
thaJeztah
changed the title
Fix this warning from go-1.11 > cli/registry/client/fetcher.go:234: Debugf format %s has arg > repoEndpoint of wrong type client.repositoryEndpoint Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 51848bf) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
In case go build will see a need to call C++ (rather than C) compiler, CXX env var need to be properly set (to osxcross wrapper). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit ee46130) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Release notes: https://golang.org/doc/devel/release.html#go1.11 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 9412739) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
gofmt/goimports changed some heuristics in 1.11 and the code is now formatted slightly differently. No functional change, just whitespace. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 906c2d1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
When building the Dockerfiles for development, those images are mainly used to create a reproducible build-environment. The source code is bind-mounted into the image at runtime; there is no need to create an image with the actual source code, and copying the source code into the image would lead to a new image being created for each code-change (possibly leading up to many "dangling" images for previous code-changes). However, when building (and using) the development images in CI, bind-mounting is not an option, because the daemon is running remotely. To make this work, the circle-ci script patched the Dockerfiles when CI is run; adding a `COPY` to the respective Dockerfiles. Patching Dockerfiles is not really a "best practice" and, even though the source code does not and up in the image, the source would still be _sent_ to the daemon for each build (unless BuildKit is used). This patch updates the makefiles, circle-ci script, and Dockerfiles; - When building the Dockerfiles locally, pipe the Dockerfile through stdin. Doing so, prevents the build-context from being sent to the daemon. This speeds up the build, and doesn't fill up the Docker "temp" directory with content that's not used - Now that no content is sent, add the COPY instructions to the Dockerfiles, and remove the code in the circle-ci script to "live patch" the Dockerfiles. Before this patch is applied (with cache): ``` $ time make -f docker.Makefile build_shell_validate_image docker build -t docker-cli-shell-validate -f ./dockerfiles/Dockerfile.shellcheck . Sending build context to Docker daemon 41MB Step 1/2 : FROM debian:stretch-slim ... Successfully built 81e14e8ad856 Successfully tagged docker-cli-shell-validate:latest 2.75 real 0.45 user 0.56 sys ``` After this patch is applied (with cache):: ``` $ time make -f docker.Makefile build_shell_validate_image cat ./dockerfiles/Dockerfile.shellcheck | docker build -t docker-cli-shell-validate - Sending build context to Docker daemon 2.048kB Step 1/2 : FROM debian:stretch-slim ... Successfully built 81e14e8ad856 Successfully tagged docker-cli-shell-validate:latest 0.33 real 0.07 user 0.08 sys ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 166856a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Ian Campbell <ijc@docker.com> (cherry picked from commit 7c8ee78) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
With a docker build cache already primed with the build image I am seeing `time make build -f docker.Makefile DOCKER_BUILDKIT=1 GO_BUILD_CACHE=n` takes more than 1 minute. By contrast `time make build -f docker.Makefile DOCKER_BUILDKIT=1 GO_BUILD_CACHE=y` takes less than 10s with a hot cache irrespective of whether the source tree has changed Signed-off-by: Ian Campbell <ijc@docker.com> (cherry picked from commit d5de835) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.2 (released 2018/11/02) includes fixes to the compiler, linker, documentation, go command, and the database/sql and go/types packages. See the milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 58f0bfc) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.4 (released 2018/12/14) includes fixes to cgo, the compiler, linker, runtime, documentation, go command, and the net/http and go/types packages. It includes a fix to a bug introduced in Go 1.11.3 that broke go get for import path patterns containing "...". See the Go 1.11.4 milestone for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.4+label%3ACherryPickApproved go1.11.3 (released 2018/12/14) - crypto/x509: CPU denial of service in chain validation golang/go#29233 - cmd/go: directory traversal in "go get" via curly braces in import paths golang/go#29231 - cmd/go: remote command execution during "go get -u" golang/go#29230 See the Go 1.11.3 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit deaf6e1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
See the milestone for details; https://github.com/golang/go/issues?q=milestone%3AGo1.11.5+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 0e9d1d3) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.6 (released 2019/03/14) includes fixes to cgo, the compiler, linker, runtime, go command, and the crypto/x509, encoding/json, net, and net/url packages. See the Go 1.11.6 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.6 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 1500105) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.7 (released 2019/04/05) includes fixes to the runtime and the net packages. See the Go 1.11.7 milestone on our issue tracker for details. https://github.com/golang/go/issues?q=milestone%3AGo1.11.7 Full diff: golang/go@go1.11.6...go1.11.7 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.9 (released 2019/04/11) fixes an issue where using the prebuilt binary releases on older versions of GNU/Linux led to failures when linking programs that used cgo. Only Linux users who hit this issue need to update. See golang/go#31293 for details Full diff: golang/go@go1.11.8...go1.11.9 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.10 (released 2019/05/06) includes fixes to the runtime and the linker. See the Go 1.11.10 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.10 Full diff: golang/go@go1.11.9...go1.11.10 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.11.11 (released 2019/06/11) includes a fix to the crypto/x509 package. See the Go 1.11.11 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.11.11 full diff: golang/go@go1.11.10...go1.11.11 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
18.09_backport_bump_golang_1.11
branch
from
c6060b4
to
9bd840b
Compare
thaJeztah
changed the title
|
rebased, and bumped to Go 1.11.11 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the 18.09 branch to Go 1.11.x, because Go 1.10 reached EOL
docker/cli:
fmtbuild target and make use of a go build cache. #1558 Add afmtbuild target and make use of a go build cache.