Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Golang 1.12.4 #1832

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Bump Golang 1.12.4 #1832

merged 1 commit into from
Apr 17, 2019

Conversation

thaJeztah
Copy link
Member

go1.12.4 (released 2019/04/11) fixes an issue where using the prebuilt
binary releases on older versions of GNU/Linux led to failures when linking
programs that used cgo. Only Linux users who hit this issue need to update.

See golang/go#31293 for details

Full diff: golang/go@go1.12.3...go1.12.4

go1.12.4 (released 2019/04/11) fixes an issue where using the prebuilt
binary releases on older versions of GNU/Linux led to failures when linking
programs that used cgo. Only Linux users who hit this issue need to update.

See golang/go#31293 for details

Full diff: golang/go@go1.12.3...go1.12.4

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

Codecov Report

Merging #1832 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1832   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files         308      308           
  Lines       21610    21610           
=======================================
  Hits        12261    12261           
  Misses       8449     8449           
  Partials      900      900

@@ -1,4 +1,4 @@
FROM dockercore/golang-cross:1.12.3@sha256:b88a6be2469d321601f87675c49d1b3f166c4c37abc5ce3e74557fc6660481be
FROM dockercore/golang-cross:1.12.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as I thought. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I thought; let's do it 😅

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Collaborator

Note that the image is still missing arm variants.

@thaJeztah
Copy link
Member Author

upstream tracking issue docker-library/golang#274

@andrewhsu
Copy link
Contributor

Looks like arm variants are now up:

$ docker manifest inspect golang:1.12.4 | jq '.manifests[].platform | select(.architecture=="arm64")'
{
  "architecture": "arm64",
  "os": "linux",
  "variant": "v8"
}

@thaJeztah
Copy link
Member Author

👍 let's merge

@thaJeztah thaJeztah merged commit 552e8d1 into docker:master Apr 17, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Apr 17, 2019
@thaJeztah thaJeztah deleted the bump_golang_1.12.4 branch April 17, 2019 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants